-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: path handling in react devtools #29199
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hi please review this again thanks cc @hoxyq |
Hey, I don't see anything wrong with this approach, but I need to test it manually, for which I don't have time at the moment. |
Hi! Current |
You can add it to |
hello! How can I run the test? I tried |
Try running this from root folder - |
hi @hoxyq I have added tests, please take a look thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Left some formatting suggestions and 1 question.
I need to test it manually before merging, will keep you updated
Thanks! |
Summary
Fix how devtools handles URLs. It
//# sourceMappingURL=x.map
How did you test this change?
works on my side