Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jest and jsdom #29026

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

jenseng
Copy link
Contributor

@jenseng jenseng commented May 8, 2024

Summary

This brings:

  • jest* up from 29.4.2 -> 29.7.0
  • jsdom up from 20.0.0 -> 22.1.0

While the latest version of jest-dom-environment still wants jsdom@^20.0.0, it can safely use at least up to jsdom@22.1.0. See jestjs/jest#13825 (comment) for details.

Upgrading to latest versions lets us improve some WheelEvent tests and will make it possible to test a much simpler FormData construction approach (see #29018)

How did you test this change?

Ran yarn test and yarn test --prod successfully

This brings:
 - jest* up from 29.4.2 -> 29.7.0
 - jsdom up from 20.0.0 -> 22.1.0

While the latest version of jest-dom-environment still wants `jsdom@^20.0.0`,
it can safely use at least up to `jsdom@22.1.0`. See jestjs/jest#13825 (comment)
for details.

Upgrading to latest versions lets us improve some WheelEvent tests and will
make it possible to test a much simpler FormData construction approach (see facebook#29018)
@react-sizebot
Copy link

Comparing: e7d213d...aebd925

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 494.06 kB 494.06 kB = 88.21 kB 88.22 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.93 kB 88.92 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against aebd925

@kassens
Copy link
Member

kassens commented May 8, 2024

Thank you for the update!

@kassens kassens merged commit 04b0588 into facebook:main May 8, 2024
38 checks passed
@kassens kassens self-requested a review May 8, 2024 17:58
Copy link

@Pea1594 Pea1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

lubieowoce added a commit to vercel/next.js that referenced this pull request May 21, 2024
### React upstream changes

-  75871d7de [ssa] Add support for other kinds of Instructions (Sathya Gunasekaran)
-  bb91cbbf6 [hir][be] Use a Map to store ObjectExpression.properties  (Sathya Gunasekaran)
-  f54d121d7 [hir][be] Use a Map to store JsxExpression.props  (Sathya Gunasekaran)
-  c347e8b6d [ssa][be] Delete dead code  (Sathya Gunasekaran)
-  152c3e81d [hir][be] Use .kind() to update and find ValueKind (Sathya Gunasekaran)
-  f4df34542 Improve playground validation, workaround lack of JSX support  (Joseph Savona)
-  a7450572f import runtime from "React.unstable_ForgetRuntime"  (Joseph Savona)
-  2f34f8501 Enable no-use-before-define validation in playground  (Joseph Savona)
-  00a58cdab Option to validate output with ESLint  (Joseph Savona)
-  94f1e6f27 Add runtime dependencies to the dependencies  (Jan Kassens)
-  eeb01b17e [ssa] Remove lambdas for update functions  (Sathya Gunasekaran)
-  b9ce8bdcf [SSA] Fix identifierID hack  (Sathya Gunasekaran)
-  379251c65 Add SSA-ify pass  (Sathya Gunasekaran)
-  9524c5848 Replace `import from '.'` with path name  (Jan Kassens)
-  95fe4ed0e Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  704d93600 [easy] rename InferReference{Capability=>Effects}  (Joseph Savona)
-  471201774 Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  46d7f4f8a Synchronize symbol names with React  (Lauren Tan)
-  b03752cbe Use for loop instead of Array.prototype.fill  (Lauren Tan)
-  90e189ae8 Add react-forget-runtime  (Jan Kassens)
-  8f42eda43 Provide full path to tsc  (Lauren Tan)
-  9e8224cc5 Pass `init` to E0007 diagnostic  (Lauren Tan)
-  33735b90f Add a ts:analyze-trace command  (Lauren Tan)
-  e939cacf9 Don't console.error in dev  (Lauren Tan)
-  101ee3a44 Allow capitalized function identifiers to be allowlisted  (Lauren Tan)
-  58100e3d6 Use CompilerError invariant  (Lauren Tan)
- facebook/react#662
-  0000ab6ca [new-arch] HIR cleanup per discussion  (Joseph Savona)
-  73059d9a4 [Playground][Nit] Add delete + overtype for autoclosing brackets  (mofeiZ)
-  144e85626 Cleanup reverse postordering  (Joseph Savona)
-  b01fbfa7f Change function parameters to type Place  (Sathya Gunasekaran)
-  5149ce0fb [new-arch] Store HIR blocks in reverse postorder  (Joseph Savona)
-  3d4130140 [new-arch] Scaffolding and fixtures for mutability lifetime inference  (Joseph Savona)
- facebook/react#651
-  beb6e1431 [new-arch] Improve reference-kind analysis  (Joseph Savona)
-  7f17dd84d Import useMemoCache from unstable name  (Jan Kassens)
-  e575e2292 Add hash of Babel plugin to Jest transform  (Jan Kassens)
-  b605fc1ab [BE] Even more permissive ref annotation comment  (Xuan Huang (黄玄))
-  a574d1598 [Fix] Control Dep Should Only Add To Defs  (Xuan Huang (黄玄))
-  19b08e67a [Bailout] When Inputs Detected In DepGraph Cycle  (Xuan Huang (黄玄))
-  cbbfba27b [new-arch][easy] Handle declarations (let/const) through codegen  (Joseph Savona)
-  90ab34650 [new-arch][easy] Codegen for switch statements  (Joseph Savona)
-  f5f914338 [new-architecture] Reassignment-safe frozenness inference  (Joseph Savona)
-  e877f89dd Allow comment annotation to be spaced  (Xuan Huang (黄玄))
-  83f3999a2 Support var declaration hoisting  (Xuan Huang (黄玄))
-  896ef251b patch makeReadOnly into playground (Mofei Zhang)
-  4e0639c2d Add makeReadOnly codegen into the compiler (Mofei Zhang)
-  72775fba1 makeReadOnly implementation  (Mofei Zhang)
- facebook/react#589
-  a33c0b897 Initial commit (Xuan Huang (黄玄))
- facebook/react#29026
lubieowoce added a commit to vercel/next.js that referenced this pull request May 21, 2024
### React upstream changes

-  75871d7de [ssa] Add support for other kinds of Instructions (Sathya Gunasekaran)
-  bb91cbbf6 [hir][be] Use a Map to store ObjectExpression.properties  (Sathya Gunasekaran)
-  f54d121d7 [hir][be] Use a Map to store JsxExpression.props  (Sathya Gunasekaran)
-  c347e8b6d [ssa][be] Delete dead code  (Sathya Gunasekaran)
-  152c3e81d [hir][be] Use .kind() to update and find ValueKind (Sathya Gunasekaran)
-  f4df34542 Improve playground validation, workaround lack of JSX support  (Joseph Savona)
-  a7450572f import runtime from "React.unstable_ForgetRuntime"  (Joseph Savona)
-  2f34f8501 Enable no-use-before-define validation in playground  (Joseph Savona)
-  00a58cdab Option to validate output with ESLint  (Joseph Savona)
-  94f1e6f27 Add runtime dependencies to the dependencies  (Jan Kassens)
-  eeb01b17e [ssa] Remove lambdas for update functions  (Sathya Gunasekaran)
-  b9ce8bdcf [SSA] Fix identifierID hack  (Sathya Gunasekaran)
-  379251c65 Add SSA-ify pass  (Sathya Gunasekaran)
-  9524c5848 Replace `import from '.'` with path name  (Jan Kassens)
-  95fe4ed0e Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  704d93600 [easy] rename InferReference{Capability=>Effects}  (Joseph Savona)
-  471201774 Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  46d7f4f8a Synchronize symbol names with React  (Lauren Tan)
-  b03752cbe Use for loop instead of Array.prototype.fill  (Lauren Tan)
-  90e189ae8 Add react-forget-runtime  (Jan Kassens)
-  8f42eda43 Provide full path to tsc  (Lauren Tan)
-  9e8224cc5 Pass `init` to E0007 diagnostic  (Lauren Tan)
-  33735b90f Add a ts:analyze-trace command  (Lauren Tan)
-  e939cacf9 Don't console.error in dev  (Lauren Tan)
-  101ee3a44 Allow capitalized function identifiers to be allowlisted  (Lauren Tan)
-  58100e3d6 Use CompilerError invariant  (Lauren Tan)
- facebook/react#662
-  0000ab6ca [new-arch] HIR cleanup per discussion  (Joseph Savona)
-  73059d9a4 [Playground][Nit] Add delete + overtype for autoclosing brackets  (mofeiZ)
-  144e85626 Cleanup reverse postordering  (Joseph Savona)
-  b01fbfa7f Change function parameters to type Place  (Sathya Gunasekaran)
-  5149ce0fb [new-arch] Store HIR blocks in reverse postorder  (Joseph Savona)
-  3d4130140 [new-arch] Scaffolding and fixtures for mutability lifetime inference  (Joseph Savona)
- facebook/react#651
-  beb6e1431 [new-arch] Improve reference-kind analysis  (Joseph Savona)
-  7f17dd84d Import useMemoCache from unstable name  (Jan Kassens)
-  e575e2292 Add hash of Babel plugin to Jest transform  (Jan Kassens)
-  b605fc1ab [BE] Even more permissive ref annotation comment  (Xuan Huang (黄玄))
-  a574d1598 [Fix] Control Dep Should Only Add To Defs  (Xuan Huang (黄玄))
-  19b08e67a [Bailout] When Inputs Detected In DepGraph Cycle  (Xuan Huang (黄玄))
-  cbbfba27b [new-arch][easy] Handle declarations (let/const) through codegen  (Joseph Savona)
-  90ab34650 [new-arch][easy] Codegen for switch statements  (Joseph Savona)
-  f5f914338 [new-architecture] Reassignment-safe frozenness inference  (Joseph Savona)
-  e877f89dd Allow comment annotation to be spaced  (Xuan Huang (黄玄))
-  83f3999a2 Support var declaration hoisting  (Xuan Huang (黄玄))
-  896ef251b patch makeReadOnly into playground (Mofei Zhang)
-  4e0639c2d Add makeReadOnly codegen into the compiler (Mofei Zhang)
-  72775fba1 makeReadOnly implementation  (Mofei Zhang)
- facebook/react#589
-  a33c0b897 Initial commit (Xuan Huang (黄玄))
- facebook/react#29026
lubieowoce added a commit to vercel/next.js that referenced this pull request May 21, 2024
### React upstream changes

-  75871d7de [ssa] Add support for other kinds of Instructions (Sathya Gunasekaran)
-  bb91cbbf6 [hir][be] Use a Map to store ObjectExpression.properties  (Sathya Gunasekaran)
-  f54d121d7 [hir][be] Use a Map to store JsxExpression.props  (Sathya Gunasekaran)
-  c347e8b6d [ssa][be] Delete dead code  (Sathya Gunasekaran)
-  152c3e81d [hir][be] Use .kind() to update and find ValueKind (Sathya Gunasekaran)
-  f4df34542 Improve playground validation, workaround lack of JSX support  (Joseph Savona)
-  a7450572f import runtime from "React.unstable_ForgetRuntime"  (Joseph Savona)
-  2f34f8501 Enable no-use-before-define validation in playground  (Joseph Savona)
-  00a58cdab Option to validate output with ESLint  (Joseph Savona)
-  94f1e6f27 Add runtime dependencies to the dependencies  (Jan Kassens)
-  eeb01b17e [ssa] Remove lambdas for update functions  (Sathya Gunasekaran)
-  b9ce8bdcf [SSA] Fix identifierID hack  (Sathya Gunasekaran)
-  379251c65 Add SSA-ify pass  (Sathya Gunasekaran)
-  9524c5848 Replace `import from '.'` with path name  (Jan Kassens)
-  95fe4ed0e Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  704d93600 [easy] rename InferReference{Capability=>Effects}  (Joseph Savona)
-  471201774 Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  46d7f4f8a Synchronize symbol names with React  (Lauren Tan)
-  b03752cbe Use for loop instead of Array.prototype.fill  (Lauren Tan)
-  90e189ae8 Add react-forget-runtime  (Jan Kassens)
-  8f42eda43 Provide full path to tsc  (Lauren Tan)
-  9e8224cc5 Pass `init` to E0007 diagnostic  (Lauren Tan)
-  33735b90f Add a ts:analyze-trace command  (Lauren Tan)
-  e939cacf9 Don't console.error in dev  (Lauren Tan)
-  101ee3a44 Allow capitalized function identifiers to be allowlisted  (Lauren Tan)
-  58100e3d6 Use CompilerError invariant  (Lauren Tan)
- facebook/react#662
-  0000ab6ca [new-arch] HIR cleanup per discussion  (Joseph Savona)
-  73059d9a4 [Playground][Nit] Add delete + overtype for autoclosing brackets  (mofeiZ)
-  144e85626 Cleanup reverse postordering  (Joseph Savona)
-  b01fbfa7f Change function parameters to type Place  (Sathya Gunasekaran)
-  5149ce0fb [new-arch] Store HIR blocks in reverse postorder  (Joseph Savona)
-  3d4130140 [new-arch] Scaffolding and fixtures for mutability lifetime inference  (Joseph Savona)
- facebook/react#651
-  beb6e1431 [new-arch] Improve reference-kind analysis  (Joseph Savona)
-  7f17dd84d Import useMemoCache from unstable name  (Jan Kassens)
-  e575e2292 Add hash of Babel plugin to Jest transform  (Jan Kassens)
-  b605fc1ab [BE] Even more permissive ref annotation comment  (Xuan Huang (黄玄))
-  a574d1598 [Fix] Control Dep Should Only Add To Defs  (Xuan Huang (黄玄))
-  19b08e67a [Bailout] When Inputs Detected In DepGraph Cycle  (Xuan Huang (黄玄))
-  cbbfba27b [new-arch][easy] Handle declarations (let/const) through codegen  (Joseph Savona)
-  90ab34650 [new-arch][easy] Codegen for switch statements  (Joseph Savona)
-  f5f914338 [new-architecture] Reassignment-safe frozenness inference  (Joseph Savona)
-  e877f89dd Allow comment annotation to be spaced  (Xuan Huang (黄玄))
-  83f3999a2 Support var declaration hoisting  (Xuan Huang (黄玄))
-  896ef251b patch makeReadOnly into playground (Mofei Zhang)
-  4e0639c2d Add makeReadOnly codegen into the compiler (Mofei Zhang)
-  72775fba1 makeReadOnly implementation  (Mofei Zhang)
- facebook/react#589
-  a33c0b897 Initial commit (Xuan Huang (黄玄))
- facebook/react#29026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants