Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment with using an object literal for Fiber creation #28734

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Experiment with using an object literal for Fiber creation #28734

merged 1 commit into from
Jul 10, 2024
+108 −25

Commits on Jul 10, 2024

  1. Experiment with using an object literal for Fiber creation 

    Object literals should be faster at least on React Native with Hermes as the JS engine.
It might also be interesting to confirm the old comments in this file from years ago are even still valid. Creating an object from a literal should be a simpler operation.

It's a bit unfortunate that this introduces a bunch of copied code, but since we rearely update the fields on fibers, this seems like an okay tradeoff for a hot code path. An alternative would be some sort of macro system, but that doesn't seem worth the extra complexity.
    @kassens
    kassens committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c2bc596 View commit details
    Browse the repository at this point in the history