Experiment with using an object literal for Fiber creation #28734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
kassens
force-pushed
the
pr28734
branch
2 times, most recently
from
834d891
to
16e5343
Compare
|
Comparing: e02baf6...f349060 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Awesome! It definitely makes sense to proceed if we can confirm that this is a perf win on Hermes. It should be given our earlier profiling results but let's check first? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The RN code from prod looks like this: function FiberNode(tag, pendingProps, key, mode) {
this.tag = tag;
this.key = key;
this.sibling =
this.child =
this.return =
this.stateNode =
this.type =
this.elementType =
null;
this.index = 0;
this.refCleanup = this.ref = null;
this.pendingProps = pendingProps;
this.dependencies =
this.memoizedState =
this.updateQueue =
this.memoizedProps =
null;
this.mode = mode;
this.subtreeFlags = this.flags = 0;
this.deletions = null;
this.childLanes = this.lanes = 0;
this.alternate = null;
}
function createFiberImplClass(tag, pendingProps, key, mode) {
return new FiberNode(tag, pendingProps, key, mode);
}
function createFiberImplObject(tag, pendingProps, key, mode) {
return {
tag: tag,
key: key,
elementType: null,
type: null,
stateNode: null,
return: null,
child: null,
sibling: null,
index: 0,
ref: null,
refCleanup: null,
pendingProps: pendingProps,
memoizedProps: null,
updateQueue: null,
memoizedState: null,
dependencies: null,
mode: mode,
flags: 0,
subtreeFlags: 0,
deletions: null,
lanes: 0,
childLanes: 0,
alternate: null
};
}
var createFiber = enableObjectFiber
? createFiberImplObject
: createFiberImplClass; |
gsathya
approved these changes
Jul 10, 2024
Object literals should be faster at least on React Native with Hermes as the JS engine. It might also be interesting to confirm the old comments in this file from years ago are even still valid. Creating an object from a literal should be a simpler operation. It's a bit unfortunate that this introduces a bunch of copied code, but since we rearely update the fields on fibers, this seems like an okay tradeoff for a hot code path. An alternative would be some sort of macro system, but that doesn't seem worth the extra complexity.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Object literals should be faster at least on React Native with Hermes as the JS engine. It might also be interesting to confirm the old comments in this file from years ago are even still valid. Creating an object from a literal should be a simpler operation. It's a bit unfortunate that this introduces a bunch of copied code, but since we rearely update the fields on fibers, this seems like an okay tradeoff for a hot code path. An alternative would be some sort of macro system, but that doesn't seem worth the extra complexity. DiffTrain build for [fe98289](fe98289)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Object literals should be faster at least on React Native with Hermes as the JS engine. It might also be interesting to confirm the old comments in this file from years ago are even still valid. Creating an object from a literal should be a simpler operation. It's a bit unfortunate that this introduces a bunch of copied code, but since we rearely update the fields on fibers, this seems like an okay tradeoff for a hot code path. An alternative would be some sort of macro system, but that doesn't seem worth the extra complexity. DiffTrain build for commit fe98289.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object literals should be faster at least on React Native with Hermes as the JS engine.
It might also be interesting to confirm the old comments in this file from years ago are even still valid. Creating an object from a literal should be a simpler operation.
It's a bit unfortunate that this introduces a bunch of copied code, but since we rearely update the fields on fibers, this seems like an okay tradeoff for a hot code path. An alternative would be some sort of macro system, but that doesn't seem worth the extra complexity.