Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out-of-band sync #18439

Closed
wants to merge 2 commits into from
Closed

Out-of-band sync #18439

wants to merge 2 commits into from

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 31, 2020

We had to revert the most recent www sync because of a bug in one of the useEvent PRs.

The sync also included some bugfixes, so I'm going to try to re-land with the useEvent PRs reverted.

I'm doing this out-of-band (not from the tip of master) to decouple it from the other changes that have landed in the meantime, mainly #18435.

Includes everything up to d7382b6, then reverts #18375 and #18395

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 31, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fe0d060:

Sandbox Source
dank-haze-t4grz Configuration

@sizebot
Copy link

sizebot commented Mar 31, 2020

Details of bundled changes.

Comparing: d7382b6...fe0d060

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 126.94 KB 126.94 KB 39.75 KB 39.75 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 3.35 KB 3.35 KB 1.27 KB 1.27 KB UMD_DEV
ReactDOM-dev.js -2.0% -1.8% 964.32 KB 945.36 KB 214.57 KB 210.68 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.19 KB 1.19 KB 699 B 698 B UMD_PROD
ReactDOM-prod.js -3.2% -3.2% 406.75 KB 393.62 KB 73.78 KB 71.4 KB FB_WWW_PROD
ReactDOM-profiling.js -3.1% -3.1% 418.23 KB 405.1 KB 75.75 KB 73.42 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 2.95 KB 2.95 KB 1.18 KB 1.18 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1 KB 1 KB 611 B 610 B NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 59.24 KB 59.24 KB 15.65 KB 15.65 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 12.26 KB 12.26 KB 4.55 KB 4.55 KB UMD_PROD
ReactDOMTesting-dev.js -2.4% -2.3% 921.54 KB 899.61 KB 205.85 KB 201.18 KB FB_WWW_DEV
ReactDOMTesting-prod.js -3.7% -3.7% 394.73 KB 380.13 KB 72 KB 69.36 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.7 KB 54.7 KB 15.04 KB 15.04 KB NODE_DEV
ReactDOMTesting-profiling.js -3.7% -3.7% 394.73 KB 380.13 KB 72 KB 69.36 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% -0.0% 129.05 KB 129.05 KB 34.3 KB 34.3 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 12.12 KB 12.12 KB 4.48 KB 4.48 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.49 KB 20.49 KB 7.52 KB 7.52 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 127.83 KB 127.83 KB 34.05 KB 34.05 KB NODE_DEV
react-dom.development.js -0.0% -0.0% 940.45 KB 940.36 KB 205.62 KB 205.59 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 57.71 KB 57.71 KB 14.37 KB 14.36 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 122.81 KB 122.81 KB 39.27 KB 39.27 KB UMD_PROD
ReactDOMForked-dev.js -2.0% -1.8% 964.32 KB 945.36 KB 214.57 KB 210.68 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.32 KB 10.32 KB 3.5 KB 3.49 KB UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 135.47 KB 135.47 KB 34.6 KB 34.6 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 126.64 KB 126.64 KB 40.54 KB 40.54 KB UMD_PROFILING
ReactDOMForked-prod.js -3.2% -3.2% 406.75 KB 393.62 KB 73.78 KB 71.4 KB FB_WWW_PROD
ReactDOMServer-prod.js 0.0% -0.0% 45.91 KB 45.91 KB 10.67 KB 10.67 KB FB_WWW_PROD
react-dom.development.js -0.0% -0.0% 895.42 KB 895.34 KB 203.11 KB 203.09 KB NODE_DEV
ReactDOMForked-profiling.js -3.1% -3.1% 418.23 KB 405.1 KB 75.75 KB 73.42 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 54.72 KB 54.72 KB 14.14 KB 14.14 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.69 KB 3.69 KB 1.34 KB 1.34 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 122.95 KB 122.95 KB 38.46 KB 38.46 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.05 KB 10.05 KB 3.38 KB 3.38 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.16 KB 1.16 KB 663 B 662 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js -0.9% -1.0% 580.8 KB 575.86 KB 122.12 KB 120.96 KB FB_WWW_DEV
ReactART-prod.js -0.2% -0.2% 242.54 KB 242.07 KB 41.15 KB 41.08 KB FB_WWW_PROD
react-art.development.js 0.0% -0.0% 658.86 KB 658.86 KB 138.36 KB 138.36 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 109.3 KB 109.3 KB 33.14 KB 33.14 KB UMD_PROD
react-art.production.min.js 0.0% -0.0% 74.29 KB 74.29 KB 22.31 KB 22.3 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% -0.0% 576.42 KB 576.42 KB 119.98 KB 119.97 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 73.73 KB 73.73 KB 22.5 KB 22.49 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 38.4 KB 38.4 KB 9.3 KB 9.3 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 12.92 KB 12.92 KB 3.94 KB 3.94 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.0% 549.5 KB 549.5 KB 118.52 KB 118.52 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 73.54 KB 73.54 KB 22.21 KB 22.21 KB NODE_PROD
ReactTestRenderer-dev.js -0.9% -0.9% 582.19 KB 577.17 KB 123.02 KB 121.87 KB FB_WWW_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against fe0d060

@sizebot
Copy link

sizebot commented Mar 31, 2020

Details of bundled changes.

Comparing: d7382b6...fe0d060

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOMTesting-profiling.js -3.5% -3.4% 407.48 KB 393.36 KB 74.04 KB 71.54 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.62 KB 19.62 KB 7.29 KB 7.29 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 3.34 KB 3.34 KB 1.26 KB 1.26 KB UMD_DEV
react-dom.profiling.min.js 0.0% -0.0% 122.67 KB 122.67 KB 38.54 KB 38.54 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 12.25 KB 12.25 KB 4.54 KB 4.54 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.17 KB 1.17 KB 691 B 690 B UMD_PROD
react-dom-server.node.development.js 0.0% -0.0% 127.53 KB 127.53 KB 34.09 KB 34.09 KB NODE_DEV
ReactDOMForked-dev.js -1.9% -1.7% 1010.18 KB 991.2 KB 224.59 KB 220.67 KB FB_WWW_DEV
ReactDOMForked-prod.js -2.9% -2.8% 432.45 KB 419.71 KB 78.31 KB 76.08 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.68 KB 3.68 KB 1.33 KB 1.33 KB NODE_DEV
react-dom.development.js -0.0% -0.0% 910.61 KB 910.52 KB 200.34 KB 200.32 KB UMD_DEV
ReactDOMForked-profiling.js -2.9% -2.7% 443.96 KB 431.22 KB 80.31 KB 78.12 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.15 KB 1.15 KB 654 B 653 B NODE_PROD
react-dom.production.min.js 0.0% -0.0% 118.74 KB 118.74 KB 38.12 KB 38.12 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 122.45 KB 122.45 KB 39.35 KB 39.35 KB UMD_PROFILING
ReactDOMTesting-dev.js -2.3% -2.3% 948.3 KB 926.36 KB 211.76 KB 206.92 KB FB_WWW_DEV
react-dom.development.js -0.0% -0.0% 866.82 KB 866.74 KB 197.91 KB 197.88 KB NODE_DEV
ReactDOMTesting-prod.js -3.5% -3.4% 407.48 KB 393.36 KB 74.04 KB 71.54 KB FB_WWW_PROD
ReactDOM-dev.js -1.9% -1.7% 1010.18 KB 991.2 KB 224.59 KB 220.67 KB FB_WWW_DEV
ReactDOM-prod.js -2.9% -2.8% 432.45 KB 419.71 KB 78.31 KB 76.08 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.69 KB 54.69 KB 15.03 KB 15.03 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.3% 2.94 KB 2.94 KB 1.17 KB 1.17 KB NODE_DEV
ReactDOM-profiling.js -2.9% -2.7% 443.96 KB 431.22 KB 80.31 KB 78.12 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 12.1 KB 12.1 KB 4.47 KB 4.47 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 57.7 KB 57.7 KB 14.36 KB 14.36 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1013 B 1013 B 603 B 602 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.31 KB 10.31 KB 3.49 KB 3.49 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 54.71 KB 54.71 KB 14.14 KB 14.14 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.04 KB 10.04 KB 3.37 KB 3.37 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% -0.0% 542.58 KB 542.58 KB 117.01 KB 117.01 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 71.72 KB 71.72 KB 21.66 KB 21.66 KB NODE_PROD
ReactART-dev.js -0.8% -0.9% 608.88 KB 603.93 KB 127.74 KB 126.63 KB FB_WWW_DEV
ReactART-prod.js -0.2% -0.2% 251.46 KB 250.99 KB 42.59 KB 42.52 KB FB_WWW_PROD
react-art.development.js 0.0% -0.0% 638.58 KB 638.58 KB 134.67 KB 134.67 KB UMD_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer-shallow.development.js 0.0% 0.0% 38.39 KB 38.39 KB 9.29 KB 9.29 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 12.91 KB 12.91 KB 3.94 KB 3.93 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.0% 549.47 KB 549.47 KB 118.51 KB 118.51 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 73.52 KB 73.52 KB 22.19 KB 22.19 KB NODE_PROD
ReactTestRenderer-dev.js -0.9% -0.9% 582.17 KB 577.16 KB 123.01 KB 121.86 KB FB_WWW_DEV
react-test-renderer.development.js 0.0% -0.0% 576.4 KB 576.4 KB 119.96 KB 119.96 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 73.71 KB 73.71 KB 22.48 KB 22.48 KB UMD_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against fe0d060

@gaearon gaearon closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @gaearon @facebook-github-bot