[ESLint] Check deps when callback body is outside the Hook call, too #18435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of visiting the functions and looking up to see if they're in a Hook call, visit Hook calls and look down to see if there's a callback inside. I will need this refactor so I can visit functions declared outside the call.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4bd4339:
|
Details of bundled changes.Comparing: ba31ad4...4bd4339 eslint-plugin-react-hooks
Size changes (experimental) |
Details of bundled changes.Comparing: ba31ad4...4bd4339 eslint-plugin-react-hooks
Size changes (stable) |
lunaruan
approved these changes
Mar 30, 2020
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16573.
We didn't use to check calls like
useEffect(effectBody, [])at all. That was dangerous. Now we do.The first commit is a refactor so that we scan any arbitrary function for deps, rather than a direct child of a Hook call. The second commit uses it to check cases like
useEffect(effectBody, [])ifeffectBodyis declared locally. If the effect body is declared outside a render scope, we don't complain. If it's passed as a prop or if we can't analyze it statically for some other way, we ask you to write it inline or to include it in deps.This is an alternative to #17443. I initially tried to build on that, but I wanted to add more heuristics and needed to refactor more significantly.