Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _ctor field from Lazy components #18217

Merged
merged 6 commits into from
Mar 5, 2020
Merged

Remove _ctor field from Lazy components #18217

merged 6 commits into from
Mar 5, 2020

Commits on Mar 5, 2020

  1. This type is all wrong and nothing cares because it's all any

    @sebmarkbage
    sebmarkbage committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    c2404c8 View commit details
    Browse the repository at this point in the history

  2. Refine Flow types of Lazy Components 

    We can type each condition.
    @sebmarkbage
    sebmarkbage committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    a1627d7 View commit details
    Browse the repository at this point in the history

  3. Remove _ctor field from Lazy components 

    This field is not needed because it's only used before we've initialized,
and we don't have anything else to store before we've initialized.
    @sebmarkbage
    sebmarkbage committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1ac618d View commit details
    Browse the repository at this point in the history

  4. Check for _ctor in case it's an older isomorphic that created it 

    We try not to break across minors but it's no guarantee.
    @sebmarkbage
    sebmarkbage committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1b37fc2 View commit details
    Browse the repository at this point in the history

  5. Move types and constants from shared to isomorphic 

    The "react" package owns the data structure of the Lazy component. It
creates it and decides how any downstream renderer may use it.
    @sebmarkbage
    sebmarkbage committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    326c710 View commit details
    Browse the repository at this point in the history

  6. Move constants to shared 

    Apparently we can't depend on react/src/ because the whole package is
considered "external" as far as rollup is concerned.
    @sebmarkbage
    sebmarkbage committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    01bf197 View commit details
    Browse the repository at this point in the history