Remove _ctor field from Lazy components #18217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can type each condition.
This field is not needed because it's only used before we've initialized, and we don't have anything else to store before we've initialized.
We try not to break across minors but it's no guarantee.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 01bf197:
|
Details of bundled changes.Comparing: 2fe0fbb...01bf197 react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Size changes (stable) |
Details of bundled changes.Comparing: 2fe0fbb...01bf197 react-art
react-dom
react-test-renderer
react-native-renderer
react-reconciler
Size changes (experimental) |
acdlite
approved these changes
Mar 5, 2020
| lazyComponent._status = Pending; | ||
| const ctor = lazyComponent._ctor; | ||
| let ctor = lazyComponent._result; | ||
| if (!ctor) { |
There was a problem hiding this comment.
When we detect existence of something unknown things we tend to do this type of check.
The "react" package owns the data structure of the Lazy component. It creates it and decides how any downstream renderer may use it.
sebmarkbage
commented
Mar 5, 2020
| export const Uninitialized = -1; | ||
| export const Pending = 0; | ||
| export const Resolved = 1; | ||
| export const Rejected = 2; |
There was a problem hiding this comment.
I also upstreamed all of this to the isomorphic package since it owns this data structure. I'll think a bit how we can move the other two helpers out of /shared.
Apparently we can't depend on react/src/ because the whole package is considered "external" as far as rollup is concerned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is not needed because it's only used before we've initialized, and we don't have anything else to store before we've initialized.
This isn't an important perf optimization by itself but this refactor is motivated by lining it up with the same work on Blocks.