Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SafeValue to ToStringValue #13376

Merged
merged 1 commit into from
Aug 13, 2018

Commits on Aug 12, 2018

  1. Rename SafeValue to ToStringValue

    Following up on the changes I made in facebook#13367, @gaearon suggest that
    "safe" could be read as necessary for security. To avoid misleading a
    reader, I'm changing the name.
    
    A few names where discussed in the previous PR. I think `ToStringValue`
    makes sense since the value itself is not a string yet but an opaque
    type that can be cast to a string. For the actual string concatenation,
    I've used `toString` now to avoid confusion: `toStringValueToString`
    is super weird and it's namespaced anyhow.
    
    Definitely open for suggestions here. :) I'll wait until we wrap up
    facebook#13362 and take care of rebase afterwards.
    philipp-spiess committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    793104a View commit details
    Browse the repository at this point in the history