Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SafeValue to ToStringValue #13376

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

philipp-spiess
Copy link
Contributor

Following up on the changes I made in #13367, @gaearon suggest that "safe" could be read as necessary for security. To avoid misleading future readers, I'm changing the name.

A few names where discussed in the previous PR. I think ToStringValue makes sense since the value itself is not a string yet but an opaque type that can be cast to a string. For the actual string concatenation, I've used toString now to avoid confusion. toStringValueToString is super weird and the function is namespaced anyway.

Definitely open for other suggestions here as well. My plan is to wait until we wrap up #13362 and then rebase afterwards.

Following up on the changes I made in facebook#13367, @gaearon suggest that
"safe" could be read as necessary for security. To avoid misleading a
reader, I'm changing the name.

A few names where discussed in the previous PR. I think `ToStringValue`
makes sense since the value itself is not a string yet but an opaque
type that can be cast to a string. For the actual string concatenation,
I've used `toString` now to avoid confusion: `toStringValueToString`
is super weird and it's namespaced anyhow.

Definitely open for suggestions here. :) I'll wait until we wrap up
facebook#13362 and take care of rebase afterwards.
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@gaearon gaearon merged commit a0190f8 into facebook:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants