[#13171] Needless checkbox warning when using onClick instead of onChange

[y-gagar1n]

Fixes #13171

Adds additional check for onClick presence before showing the warning.

[gaearon]

Are there any cases where React's onChange fires but onClick doesn't?

[philipp-spiess]

Nope, we internally use onClick as well:

react/packages/react-dom/src/events/ChangeEventPlugin.js

Lines 210 to 226 in 606c30a

	function shouldUseClickEvent(elem) {
	// Use the `click` event to detect changes to checkbox and radio inputs.
	// This approach works across all browsers, whereas `change` does not fire
	// until `blur` in IE8.
	const nodeName = elem.nodeName;
	return (
	nodeName &&
	nodeName.toLowerCase() === 'input' &&
	(elem.type === 'checkbox' || elem.type === 'radio')
	);
	}
	function getTargetInstForClickEvent(topLevelType, targetInst) {
	if (topLevelType === TOP_CLICK) {
	return getInstIfValueChanged(targetInst);
	}
	}

[gaearon]

Hmm. Then what's the use of allowing both events in this case? Seems like nudging towards just one makes it easier for e.g. third party component developers who need to decide on their event naming.

[philipp-spiess]

I also think that makes more sense. It's also more consistent as we currently require an onChange handler for all controlled inputs IIRC.

[gaearon]

Okay, I'll close it then. There are no benefits to using onClick in React — so let's keep the warning to encourage consistency.