-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needless checkbox warning when using onClick instead of onChange #13171
Comments
Worth pointing out: much of that answer refers to a bug in Internet Explorer which was actually fixed in IE9+. React DOM doesn't support IE8 or lower any more anyway. |
ya we have a pending PR for that: #10830 |
That answer doesn't apply to React. In fact React internally uses You can keep using |
We can, however, revisit this at the same time as we merge #10830. |
Do you want to request a feature or report a bug?
A very minor bug.
What is the current behavior?
When using a checkbox with
onClick
, I get the following warning:But my checkbox works well and actually,
onClick
is the better solution according to https://stackoverflow.com/a/4471462/581205.What is the expected behavior?
No warning when
onClick
is set.Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
"react": "^16.4.1"
And thanks for the good software!
The text was updated successfully, but these errors were encountered: