feat: Add tvOS support to Hermes artifacts #46865
Open
+37
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
douglowder
force-pushed
the
hermes-tvos
branch
from
f67cc95
to
d9773eb
Compare
cipolleschi
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Hi @douglowder, thanks for the PR. I believe we should drop the maven_local changes as there is nothing related to iOS there.
packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds tvOS to the list of Apple platforms supported by the Hermes artifacts. After this, the React Native TV builds will be able to use the same Hermes artifacts as those used by RN core.
Added some code in
hermes-utils.rbso that the Hermes podspec can use a local Maven repo (/tmp/maven-local).Changelog:
[iOS][Added] tvOS support for Hermes artifacts
Test Plan: