feat: add tvOS support #1529
Open
feat: add tvOS support #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
douglowder
added a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Oct 6, 2024
- Test exact changes submitted in facebook/hermes#1529
|
RNTester CI build seems to be working fine: https://github.com/react-native-tvos/react-native-tvos/releases/tag/v0.76.0-0test2 |
douglowder
added a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Oct 6, 2024
- Test exact changes submitted in facebook/hermes#1529
- Align with earlier PR to add VisionOS test (facebook#1528)
cipolleschi
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
@douglowder thankss for looking into this and for opening this PR.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Apple TV support for Hermes.
Note: This support requires a few source file changes to work around code that will not compile for tvOS. Comments containing the compiler errors have been added.
Test Plan