Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BackgroundDrawable to replace background logic on CSSBackgroundDrawable #46709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add BackgroundDrawable to replace background logic on CSSBackgroundDrawable #46709

wants to merge 2 commits into from

Commits on Oct 9, 2024

  1. Nullable borderRadius optimization on shadows and outline 

    Differential Revision: D63798853
    @jorge-cab @facebook-github-bot
    jorge-cab authored and facebook-github-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3630df5 View commit details
    Browse the repository at this point in the history

  2. Add BackgroundDrawable to replace background logic on `CSSBackgroun… 

    …dDrawable` (facebook#46709)

Summary:
Pull Request resolved: facebook#46709

**Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing

`CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things.

We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view.

By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file

Also, this helps  with the kotlinification efforts

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D63137921
    @jorge-cab @facebook-github-bot
    jorge-cab authored and facebook-github-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    215b03b View commit details
    Browse the repository at this point in the history