Add BackgroundDrawable to replace background logic on CSSBackgroundDrawable
#46709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 30, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Differential Revision: D63137921
jorge-cab
force-pushed
the
export-D63137921
branch
from
98c1eb3
to
0875158
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
force-pushed
the
export-D63137921
branch
from
0875158
to
9f07928
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 30, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Differential Revision: D63137921
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 2, 2024
…dDrawable`, Merge into one (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Differential Revision: D63137921 Reviewed By: NickGerleman
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
force-pushed
the
export-D63137921
branch
from
9f07928
to
88f09ca
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 2, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63137921
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 3, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63137921
jorge-cab
force-pushed
the
export-D63137921
branch
from
88f09ca
to
29b112e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 3, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63137921
jorge-cab
force-pushed
the
export-D63137921
branch
from
29b112e
to
f7acad1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 3, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63137921
jorge-cab
force-pushed
the
export-D63137921
branch
from
f7acad1
to
a235552
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 8, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63137921
jorge-cab
force-pushed
the
export-D63137921
branch
from
a235552
to
49fed8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 9, 2024
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63137921
jorge-cab
force-pushed
the
export-D63137921
branch
from
49fed8b
to
39ce039
Compare
Differential Revision: D63798853
…dDrawable` (facebook#46709) Summary: Pull Request resolved: facebook#46709 **Note:** This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing `CSSBackgroundDrawable` holds the drawing logic for both **Borders** and **Background**. This is not ideal since it results in a huge file which does 2 things. We now have `CompositeBackgroundDrawable` which allows us to set a different drawable per "layer" on our view. By splitting up **Border** and **Background** logic we get better modularity and it'll make it easier to implement more `backgroundImage` features without further bloating the `CSSBackgroundDrawable` file Also, this helps with the kotlinification efforts Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63137921
|
This pull request was exported from Phabricator. Differential Revision: D63137921 |
jorge-cab
force-pushed
the
export-D63137921
branch
from
39ce039
to
215b03b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Note: This diff still does nothing yet, it will be enabled on a diff further up the stack. This split is just to simplify reviewing
CSSBackgroundDrawableholds the drawing logic for both Borders and Background. This is not ideal since it results in a huge file which does 2 things.We now have
CompositeBackgroundDrawablewhich allows us to set a different drawable per "layer" on our view.By splitting up Border and Background logic we get better modularity and it'll make it easier to implement more
backgroundImagefeatures without further bloating theCSSBackgroundDrawablefileAlso, this helps with the kotlinification efforts
Changelog: [Internal]
Differential Revision: D63137921