Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release #38212

Closed
wants to merge 1 commit into from
Closed

Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release #38212

wants to merge 1 commit into from

Commits on Jul 6, 2023

  1. Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release (f… 

    …acebook#38212)

Summary:
Pull Request resolved: facebook#38212

This mirrors the same logic that the Hermes team has on facebook/hermes.
Practically, we want to pass the CMake config flag `HERMES_ENABLE_DEBUGGER=False` only for Release
so that their CMake build is configured correctly.

Their build always enables the Debugger and allows us to selectively turn it off only for release
builds.

More context: facebook/hermes@eabf5fcd25

Changelog:
[Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release

Reviewed By: cipolleschi

Differential Revision: D47252735

fbshipit-source-id: 8096c8389a045ac0c56ace20ea3be2c1fa03603f
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    dc0192e View commit details
    Browse the repository at this point in the history