Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release #38212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47252735 |
…acebook#38212) Summary: Pull Request resolved: facebook#38212 This mirrors the same logic that the Hermes team has on facebook/hermes. Practically, we want to pass the CMake config flag `HERMES_ENABLE_DEBUGGER=False` only for Release so that their CMake build is configured correctly. Their build always enables the Debugger and allows us to selectively turn it off only for release builds. More context: facebook/hermes@eabf5fcd25 Changelog: [Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release Reviewed By: cipolleschi Differential Revision: D47252735 fbshipit-source-id: 8096c8389a045ac0c56ace20ea3be2c1fa03603f
cortinico
force-pushed
the
export-D47252735
branch
from
0e0b97d
to
dc0192e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47252735 |
Base commit: 41477c8 |
|
This pull request has been merged in 86b5b4c. |
kelset
pushed a commit
that referenced
this pull request
Jul 10, 2023
…38212) Summary: Pull Request resolved: #38212 This mirrors the same logic that the Hermes team has on facebook/hermes. Practically, we want to pass the CMake config flag `HERMES_ENABLE_DEBUGGER=False` only for Release so that their CMake build is configured correctly. Their build always enables the Debugger and allows us to selectively turn it off only for release builds. More context: facebook/hermes@eabf5fcd25 Changelog: [Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release Reviewed By: cipolleschi Differential Revision: D47252735 fbshipit-source-id: 9b5cd801dea3b540a3f80b0d0975e05984f1d9b9
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 11, 2023
…acebook#38212) Summary: Pull Request resolved: facebook#38212 This mirrors the same logic that the Hermes team has on facebook/hermes. Practically, we want to pass the CMake config flag `HERMES_ENABLE_DEBUGGER=False` only for Release so that their CMake build is configured correctly. Their build always enables the Debugger and allows us to selectively turn it off only for release builds. More context: facebook/hermes@eabf5fcd25 Changelog: [Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release Reviewed By: cipolleschi Differential Revision: D47252735 fbshipit-source-id: 9b5cd801dea3b540a3f80b0d0975e05984f1d9b9
This was referenced Aug 1, 2023
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This mirrors the same logic that the Hermes team has on facebook/hermes.
Practically, we want to pass the CMake config flag
HERMES_ENABLE_DEBUGGER=Falseonly for Releaseso that their CMake build is configured correctly.
Their build always enables the Debugger and allows us to selectively turn it off only for release
builds.
More context: facebook/hermes@eabf5fcd25
Changelog:
[Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release
Reviewed By: cipolleschi
Differential Revision: D47252735