Convert FallbackJSBundleLoaderTest to Kotlin #37750
Conversation
facebook-github-bot
added
the
CLA Signed
|
@cortinico and @mdvacca could you please review? Thanks! |
Base commit: 08dc0a6 |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Thanks for sending this @fabioh8010
I've left some comments that needs to be addressed before we can merge this. Thanks for doing this work.
| import org.mockito.Mockito.`when` as whenever | ||
|
|
||
| class FallbackJSBundleLoaderTest { | ||
| private lateinit var mLoggingDelegate: FakeLoggingDelegate |
There was a problem hiding this comment.
| private lateinit var mLoggingDelegate: FakeLoggingDelegate | |
| private lateinit var loggingDelegate: FakeLoggingDelegate |
| init { | ||
| val prefix = FallbackJSBundleLoader.RECOVERABLE | ||
| val first = prefix[0] | ||
|
|
||
| UNRECOVERABLE = prefix.replace(first, (first.code + 1).toChar()) | ||
| } |
There was a problem hiding this comment.
This is really not great and we should refactor it a bit.
Having tests rely on the init{} block of a companion object is really unpredictable.
Let's remove the companion object and let's move all the logic to private methods and initialize the stuff inside the setup method
| assertThat(e).isInstanceOf(RuntimeException::class.java) | ||
|
|
||
| var cause = e.cause | ||
| val msgs = ArrayList<String?>() |
There was a problem hiding this comment.
| val msgs = ArrayList<String?>() | |
| val msgs = mutableListOf<String>() |
...ct-native/ReactAndroid/src/test/java/com/facebook/react/bridge/FallbackJSBundleLoaderTest.kt
Show resolved
Hide resolved
|
Hi @cortinico , I addressed the changes and also formatted the code with |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
* main: (1824 commits) Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750) Migrate JSPackagerClientTest to Kotlin (facebook#37747) (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746) Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745) Move flow-typed definitions to repo root (facebook#37636) Convert InterpolatorTypeTest to Kotlin (facebook#37724) Update documentation of ReactHost.reload method (facebook#37691) Reduce visibility of ReactHost.destroy() method (facebook#37693) Reduce visibility in React Context (facebook#37695) Remove InstanceHandleHelper as unused (facebook#37740) Convert CompositeReactPackageTest to Kotlin (facebook#37734) Add license header to SetSpanOperation.java Convert FakeEventDispatcher to kotlin (facebook#37739) Convert FakeRCTEventEmitter to Kotlin (facebook#37733) Convert InteropModuleRegistryTest to Kotlin (facebook#37735) Bump `autorebase.yml` to `v1.8` (facebook#37584) Convert StackTraceHelperTest to Kotlin (facebook#37741) Convert BlobModuleTest class to Kotlin (facebook#37719) Update prettier to v2.8.8 (facebook#37738) Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744) ... # Conflicts: # BUCK # packages/react-native/React/Views/UIResponder+FirstResponder.h # packages/react-native/React/Views/UIResponder+FirstResponder.m
Summary:
This PR converts FallbackJSBundleLoaderTest.java to Kotlin as requested in this issue.
Changelog:
[INTERNAL] [CHANGED] - Convert FallbackJSBundleLoaderTest to Kotlin
Test Plan:
./gradlew :packages:react-native:ReactAndroid:test.