(refactor): kotlin-ify ShareModuleTest.java
#37746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
siddarthkay
force-pushed
the
refactor/share-module-test-kotlin
branch
from
3d490a0
to
36ab3a4
Compare
Base commit: 08dc0a6 |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Thanks for sending this @siddarthkay
I've left a minor nit that needs to be addressed before we can merge this. Thanks for doing this work.
Comment on lines
34
to
35
| private var activity: Activity? = null | ||
| private var shareModule: ShareModule? = null |
There was a problem hiding this comment.
Suggested change
| private var activity: Activity? = null | |
| private var shareModule: ShareModule? = null | |
| private lateinit var activity: Activity | |
| private lateinit var shareModule: ShareModule |
|
|
||
| val promise = SimplePromise() | ||
|
|
||
| shareModule?.share(content, dialogTitle, promise) |
There was a problem hiding this comment.
If you use lateinit, all those ?. can go
|
@cortinico : Thanks for teaching me something new about |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 8, 2023
* main: (1824 commits) Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750) Migrate JSPackagerClientTest to Kotlin (facebook#37747) (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746) Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745) Move flow-typed definitions to repo root (facebook#37636) Convert InterpolatorTypeTest to Kotlin (facebook#37724) Update documentation of ReactHost.reload method (facebook#37691) Reduce visibility of ReactHost.destroy() method (facebook#37693) Reduce visibility in React Context (facebook#37695) Remove InstanceHandleHelper as unused (facebook#37740) Convert CompositeReactPackageTest to Kotlin (facebook#37734) Add license header to SetSpanOperation.java Convert FakeEventDispatcher to kotlin (facebook#37739) Convert FakeRCTEventEmitter to Kotlin (facebook#37733) Convert InteropModuleRegistryTest to Kotlin (facebook#37735) Bump `autorebase.yml` to `v1.8` (facebook#37584) Convert StackTraceHelperTest to Kotlin (facebook#37741) Convert BlobModuleTest class to Kotlin (facebook#37719) Update prettier to v2.8.8 (facebook#37738) Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744) ... # Conflicts: # BUCK # packages/react-native/React/Views/UIResponder+FirstResponder.h # packages/react-native/React/Views/UIResponder+FirstResponder.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR converts the java logic inside of
ShareModuleTest.javato Kotlin as requested in #37708We also swap
ShareModuleTest.javaforShareModuleTest.ktChangelog:
[Internal][Changed]: Convert ShareModuleTest to Kotlin
Test Plan:
./gradlew :packages:react-native:ReactAndroid:testmust pass and CI must be greenScreenshot of passing tests locally