Add desktop platform-related stylesheet props #21027
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ReactPropTypes and Flow definitions for two style properties that are not useful for mobile platforms, but will be useful for desktop implementations:
cursor
- for setting what the cursor's style will be when hovering over a<View />
appRegion
- to makeView
s into draggable areas of a window, and also for marking children of said views non-draggable (like buttons). This is named after the--webkit-app-region
property seen in Chrome apps and Electron appsThese could also be utilized by React Native Dom and React Native Web. (mapping
appRegion
back to--webkit-app-region
)Test Plan:
In a test project I was able to use
appRegion
andcursor
in aStyleSheet
and haveflow check
pass.Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/StyleSheet/DesktopPropTypes.js] - Added Desktop Prop Types
[GENERAL] [ENHANCEMENT] [Libraries/Components/View/ViewStylePropTypes.js] - Added Desktop Prop Types
[GENERAL] [ENHANCEMENT] [Libraries/StyleSheet/StyleSheetTypes.js] - Added Desktop style flow types
[GENERAL] [ENHANCEMENT] [Libraries/StyleSheet/StyleSheet.js] - Added Desktop style flow types