If source.method is "post", use HTTP POST method #21010
Conversation
The React Native Web View takes a method option to determine if HTTP GET or HTTP POST should be used. For iPhone this is not case sensitive, meaning that `method: "post"` is allowed. For Android "post" is not understood and therefore the request will be using HTTP GET. I suggest we ignore case for the method, or throw an Exception.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
react-native-bot
added
🌐Networking
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
react-native-bot
added
✅Release Notes
and removed
Missing Changelog
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dignite merged commit 6e7ffff into Once this commit is added to a release, you will see the corresponding version tag below the description at 6e7ffff. If the commit has a single |
Summary: The React Native Web View takes a method option to determine if HTTP GET or HTTP POST should be used. For iPhone this is not case sensitive, meaning that `method: "post"` is allowed. For Android "post" is not understood and therefore the request will be using HTTP GET. I suggest we ignore case for the method, or throw an Exception. Pull Request resolved: facebook#21010 Differential Revision: D9700895 Pulled By: hramos fbshipit-source-id: 3fa904e7946dd40958cb44f9a234ee66cb68fab2
hramos
removed
Import Started
Summary: The React Native Web View takes a method option to determine if HTTP GET or HTTP POST should be used. For iPhone this is not case sensitive, meaning that `method: "post"` is allowed. For Android "post" is not understood and therefore the request will be using HTTP GET. I suggest we ignore case for the method, or throw an Exception. Pull Request resolved: facebook#21010 Differential Revision: D9700895 Pulled By: hramos fbshipit-source-id: 3fa904e7946dd40958cb44f9a234ee66cb68fab2
The React Native Web View takes a method option to determine if HTTP GET or HTTP POST should be used.
For iPhone this is not case sensitive, meaning that
method: "post"is allowed.For Android "post" is not understood and therefore the request will be using HTTP GET.
I suggest we ignore case for the method, or throw an Exception.
Test Plan:
Given that I add a
<WebView />withsource.methodas lowercase"post"and source.uri ashttp://httpbin.org/postWhen I view the WebView
Then the web view should show post data
It should not say "Method not allowed"
Release Notes:
[ANDROID] [BUGFIX] [WebView] - Use postUrl if method is "post"