[Circle CI] Add Danger and publish to npm #16350
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,15 +19,16 @@ aliases: | |
| - website/node_modules | ||
| key: v1-website-dependencies-{{ .Branch }}-{{ checksum "website/package.json" }} | ||
|
|
||
| - &restore-cache-analysis | ||
| keys: | ||
| - v1-analysis-dependencies-{{ .Branch }}-{{ checksum "package.json" }}{{ checksum "danger/package.json" }} | ||
| # Fallback in case checksum fails | ||
| - v1-analysis-dependencies-{{ .Branch }}- | ||
| - &save-cache-analysis | ||
| paths: | ||
| - danger/node_modules | ||
| - node_modules | ||
| key: v1-analysis-dependencies-{{ .Branch }}-{{ checksum "package.json" }}{{ checksum "danger/package.json" }} | ||
|
|
||
| - &restore-cache-android-packages | ||
| keys: | ||
|
|
@@ -84,52 +85,57 @@ defaults: &defaults | |
|
|
||
| version: 2 | ||
| jobs: | ||
| test-javascript-node-8: | ||
| <<: *defaults | ||
| docker: | ||
| - image: circleci/node:8 | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Install Dependencies | ||
| command: | | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install --no-package-lock | ||
| - run: | | ||
| npm test -- --maxWorkers=2 | ||
| npm run lint | ||
| npm run flow -- check | ||
|
|
||
| test-javascript-node-6: | ||
|
There was a problem hiding this comment. Sure. Feel free to edit the file on the PR (if you have access) There was a problem hiding this comment. Ah, true, will play around :) |
||
| <<: *defaults | ||
| docker: | ||
| - image: circleci/node:6.11.0 | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Install Dependencies | ||
| command: | | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install | ||
| - run: | | ||
| npm test -- --maxWorkers=2 | ||
| npm run lint | ||
| npm run flow -- check | ||
|
|
||
| test-javascript-node-4: | ||
|
There was a problem hiding this comment. I think |
||
| <<: *defaults | ||
| docker: | ||
| - image: circleci/node:4.8.4 | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Install Dependencies | ||
| command: | | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install | ||
| - run: | | ||
| npm test -- --maxWorkers=2 | ||
| npm run lint | ||
| npm run flow -- check | ||
|
|
||
| test-website: | ||
| <<: *defaults | ||
| docker: | ||
|
|
@@ -140,6 +146,8 @@ jobs: | |
| name: Install Dependencies | ||
| command: | | ||
| cd website | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install --no-package-lock | ||
| - run: | ||
| name: Test Website | ||
|
|
@@ -160,6 +168,8 @@ jobs: | |
| name: Install Dependencies | ||
| command: | | ||
| cd website | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install --no-package-lock | ||
| - run: | ||
| name: Build and Deploy Static Website | ||
|
|
@@ -168,7 +178,6 @@ jobs: | |
| git config --global user.email "reactjs-bot@users.noreply.github.com" | ||
| git config --global user.name "Website Deployment Script" | ||
| echo "machine github.com login reactjs-bot password $GITHUB_TOKEN" > ~/.netrc | ||
| echo "Deploying website..." | ||
| cd website && GIT_USER=reactjs-bot npm run gh-pages | ||
| else | ||
|
|
@@ -181,7 +190,12 @@ jobs: | |
| - image: circleci/node:8 | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Install Dependencies | ||
| command: | | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install --no-package-lock | ||
| - run: | ||
| name: Build JavaScript Bundle | ||
| command: node local-cli/cli.js bundle --max-workers 2 --platform android --dev true --entry-file ReactAndroid/src/androidTest/js/TestBundle.js --bundle-output ReactAndroid/src/androidTest/assets/AndroidTestBundle.js | ||
|
|
@@ -258,7 +272,12 @@ jobs: | |
| command: | | ||
| curl -sL https://deb.nodesource.com/setup_8.x | sudo -E bash - | ||
| sudo apt-get install -y nodejs | ||
| - run: | ||
| name: Install Node Dependencies | ||
| command: | | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install --no-package-lock | ||
| # - restore-cache: *restore-cache-watchman | ||
| # - run: | ||
| # name: Install Watchman Dependencies | ||
|
|
@@ -346,15 +365,90 @@ jobs: | |
| - store_artifacts: | ||
| path: ~/junit | ||
|
|
||
| analyze-pull-request: | ||
| <<: *defaults | ||
| docker: | ||
| - image: circleci/node:8 | ||
| steps: | ||
| - checkout | ||
| - restore-cache: *restore-cache-analysis | ||
| - run: | ||
| name: Install Dependencies | ||
| command: | | ||
| if [ -n "$CIRCLE_PULL_REQUEST" ]; then | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install --no-package-lock | ||
| npm install github@0.2.4 | ||
| cd danger | ||
| npm install --no-package-lock | ||
| else | ||
| echo "Skipping dependency installation." | ||
| fi | ||
| - save-cache: *save-cache-analysis | ||
| # Run Danger | ||
| - run: | ||
| name: Analyze Pull Request | ||
| command: | | ||
| if [ -n "$CIRCLE_PULL_REQUEST" ]; then | ||
| cd danger && DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger | ||
| else | ||
| echo "Skipping pull request analysis." | ||
| fi | ||
| when: always | ||
| # Run eslint | ||
| - run: | ||
| name: Analyze Code | ||
| command: | | ||
| if [ -n "$CIRCLE_PULL_REQUEST" ]; then | ||
| cat <(echo eslint; npm run lint --silent -- --format=json; echo flow; npm run flow --silent -- check --json) | GITHUB_TOKEN="af6ef0d15709bc91d""06a6217a5a826a226fb57b7" CI_USER=$CIRCLE_PROJECT_USERNAME CI_REPO=$CIRCLE_PROJECT_REPONAME PULL_REQUEST_NUMBER=$CIRCLE_PR_NUMBER node bots/code-analysis-bot.js | ||
| else | ||
| echo "Skipping code analysis." | ||
| fi | ||
|
|
||
| publish-npm: | ||
|
There was a problem hiding this comment. Discussion here: #16348 (comment) |
||
| <<: *defaults | ||
| docker: | ||
| - image: circleci/node:8 | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Install Dependencies | ||
| command: | | ||
| npm config set spin=false | ||
| npm config set progress=false | ||
| npm install --no-package-lock | ||
| - run: | ||
| name: Publish React Native Package | ||
| command: | | ||
| if [ -z "$CIRCLE_PULL_REQUEST" ]; then | ||
| echo "//registry.npmjs.org/:_authToken=${CIRCLE_NPM_TOKEN}" > ~/.npmrc | ||
| git config --global user.email "reactjs-bot@users.noreply.github.com" | ||
| git config --global user.name "Website Deployment Script" | ||
| echo "machine github.com login reactjs-bot password $GITHUB_TOKEN" > ~/.netrc | ||
| node ./scripts/publish-npm.js | ||
| else | ||
| echo "Skipping publication." | ||
| fi | ||
|
|
||
| # Workflows enables us to run multiple jobs in parallel | ||
| workflows: | ||
| version: 2 | ||
| test_node: | ||
| jobs: | ||
| - test-javascript-node-8 | ||
| - test-javascript-node-6 | ||
| # Node 4 tests are already failing on Circle 1.0 | ||
| # - test-javascript-node-4 | ||
| test_android: | ||
| jobs: | ||
| - build-js-bundle: | ||
| filters: | ||
| branches: | ||
| ignore: gh-pages | ||
| - test-android: | ||
| requires: | ||
| - build-js-bundle | ||
| website: | ||
| jobs: | ||
| - test-website | ||
|
|
@@ -366,12 +460,20 @@ workflows: | |
| only: | ||
| - /.*-stable/ | ||
| - master | ||
| analyze: | ||
| jobs: | ||
| - analyze-pull-request: | ||
| filters: | ||
| branches: | ||
| ignore: | ||
| - master | ||
| - gh-pages | ||
| - /.*-stable/ | ||
| deploy: | ||
| jobs: | ||
| - publish-npm: | ||
| filters: | ||
| branches: | ||
| only: | ||
| - /.*-stable/ | ||
| - master | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a common step for
npm installjust like we did for cache restoration and use it like this? We seem to be repeating that over and over in many places.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I like what you did in the other PR.