[Circle CI] Add Danger and publish to npm #16350
Conversation
facebook-github-bot
added
the
CLA Signed
.circleci/config.yml
Outdated
|
|
||
| test-node-6: | ||
| test-javascript-node-6: |
There was a problem hiding this comment.
Sure. Feel free to edit the file on the PR (if you have access)
There was a problem hiding this comment.
Ah, true, will play around :)
.circleci/config.yml
Outdated
| name: Install Dependencies | ||
| command: | | ||
| npm config set spin=false | ||
| npm config set progress=false |
There was a problem hiding this comment.
Can we make a common step for npm install just like we did for cache restoration and use it like this? We seem to be repeating that over and over in many places.
There was a problem hiding this comment.
Agreed. I like what you did in the other PR.
.circleci/config.yml
Outdated
| - run: | | ||
| npm test -- --maxWorkers=2 | ||
| npm run lint | ||
| npm run flow -- check | ||
|
|
||
| test-node-4: | ||
| test-javascript-node-4: |
There was a problem hiding this comment.
I think js is more concise?
| echo "Skipping code analysis." | ||
| fi | ||
|
|
||
| publish-npm: |
There was a problem hiding this comment.
Discussion here: #16348 (comment)
|
I will also test this PR on my (feature branch). Historically, some builds were failing. Will wait with this once we finish the config itself. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Test Plan
Run on Circle