Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Animated - Override __makeNative in AnimatedInterpolation #15077

Closed
wants to merge 1 commit into from
Closed

Native Animated - Override __makeNative in AnimatedInterpolation #15077

wants to merge 1 commit into from

Commits on Jul 18, 2017

  1. Native Animated - Override __makeNative in AnimatedInterpolation 

    Summary:
Fixes the error `Trying to update interpolation node that has not been
attached to the parent` in android which occurs when using multiple
Animated.Values along with interpolation and an animation is run before
another one that uses interpolation. On ios, no error is thrown in such
case but the animation also doesn't work as expected.

You can check the snack code here which works properly without
useNativeDriver: true. But fails on android and skips the first stage
of animation on ios.
  https://snack.expo.io/HyD3zdjSZ

**Test Plan**
The animations worked properly after the __makeNative override made
the parent node native as well.
    @syaau
    syaau committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    cef5fe7 View commit details
    Browse the repository at this point in the history