Native Animated - Override __makeNative in AnimatedInterpolation #15077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes the error `Trying to update interpolation node that has not been attached to the parent` in android which occurs when using multiple Animated.Values along with interpolation and an animation is run before another one that uses interpolation. On ios, no error is thrown in such case but the animation also doesn't work as expected. You can check the snack code here which works properly without useNativeDriver: true. But fails on android and skips the first stage of animation on ios. https://snack.expo.io/HyD3zdjSZ **Test Plan** The animations worked properly after the __makeNative override made the parent node native as well.
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thanks for the fix! Looks good. |
janicduplessis
approved these changes
Jul 18, 2017
facebook-github-bot
added
GH Review: accepted
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Wow so timely, I just ran into this bug today. What version does this land in? |
|
Most likely 0.48. A quick hack into the |
|
@syaau thanks! Yep that's how I'm doing it. Very cool thanks! |
|
Hey all, I was wondering if I'm right here, this PR landed in v0.49.1? Is this correct? |
|
@Noitidart Yes, you can check the tags on the commit to know in which release it is in.
|
|
Awesome thank you sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes the error
Trying to update interpolation node that has not been attached to the parentin android which occurs when using multipleAnimated.Values along with interpolation and an animation is run before
another one that uses interpolation. On ios, no error is thrown in such
case but the animation also doesn't work as expected.
You can check the snack code here which works properly without
useNativeDriver: true. But fails on android and skips the first stage
of animation on ios.
https://snack.expo.io/HyD3zdjSZ
Test Plan
The animations worked properly after the __makeNative override made
the parent node native as well.