Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from the source is broken #17742

Closed
SandroMachado opened this issue Jan 25, 2018 · 3 comments
Closed

Building from the source is broken #17742

SandroMachado opened this issue Jan 25, 2018 · 3 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@SandroMachado
Copy link
Contributor

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 5.0.0
Yarn: 0.21.3
npm: 3.3.6
Watchman: 4.6.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.0.0 => 16.0.0
react-native: master => master

Steps to Reproduce

  1. run npm install
  2. run ./scripts/packager.sh

Expected Behavior

❯ ./scripts/packager.sh
./scripts/packager.sh: line 11: ./scripts/.packager.env: No such file or directory
Scanning folders for symlinks in /Users/sandromachado/Desktop/temp/react-native/node_modules (15ms)
┌──────────────────────────────────────────────────────────────────────────────┐
│                                                                              │
│  Running Metro Bundler on port 8081.                                         │
│                                                                              │
│  Keep Metro running while developing on any JS projects. Feel free to        │
│  close this tab and run your own Metro instance if you prefer.               │
│                                                                              │
│  https://github.com/facebook/react-native                                    │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

Looking for JS files in
   /Users/<user-directory>/Desktop/temp/react-native


Metro Bundler ready.

Loading dependency graph, done.
 BUNDLE  [android, dev] RNTester/js/RNTesterApp.android.js ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100.0% (585/585), done.

I think that this commit introduced the issue.

Actual Behavior

Loading dependency graph, done.
warning: the transform cache was reset.
error: bundling failed: Error: Unable to resolve module `metro/src/lib/bundle-modules/HMRClient` from `/Users/<user-directory>/Desktop/temp/react-native/Libraries/Utilities/HMRClient.js`: Module does not exist in the module map

Reproducible Demo

To get a demo just clone the source code from the master and execute the repro steps.

TomSwift pushed a commit to Remitly/react-native that referenced this issue Jan 26, 2018
douglowder added a commit to douglowder/react-native that referenced this issue Jan 30, 2018
@bvaughn
Copy link
Contributor

bvaughn commented Feb 2, 2018

Applying e048bf1 locally fixed the issue for me.

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 24, 2018
@hramos hramos reopened this Feb 24, 2018
@facebook facebook deleted a comment from salmanwaheed Mar 5, 2018
@hramos
Copy link
Contributor

hramos commented Mar 5, 2018

This is fixed in master.

@hramos hramos closed this as completed Mar 5, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Mar 5, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants