Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forked react-native Module with no changes fails on Package manager #17848

Closed
StreethawkNick opened this issue Feb 3, 2018 · 1 comment
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@StreethawkNick
Copy link

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

yes

Environment

Steps to Reproduce

  1. Fork a repo of React Native https://github.com/StreethawkNick/react-native
  2. This Forked repo only added a single log.e() message in any Android native java code or 1 small change.
  3. Follow tutorial on https://facebook.github.io/react-native/docs/android-building-from-source.html
  4. Build succeeded but failed on react-native start

package manager error:
HMRClient unable to resolve module 'metro/src/lib/bundle-modules/HMRClient.js`
in HMRClient.js

on this line
const MetroHMRClient = require('metro/src/lib/bundle-modules/HMRClient');

Expected Behavior

Build works, and i thought package manager will work too.

Actual Behavior

image

Reproducible Demo

https://github.com/StreethawkNick/react-native

please try build any project or simple project using this forked repo. In which the only changes were adding Log.e() loglines it has no build errors.

Thanks for helping us help you!
-->

@StreethawkNick
Copy link
Author

Solved this issue:
Related to #17742

Applying e048bf1 locally fixed the issue for me.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 4, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants