2015-02-07 updates

- Random little fixes | Andres Suarez - Add backButtonTitle to Navigator | Nick Poulden - [react-pacakger] Ignore malformed package.json | Amjad Masad - Renamed hasMove to hasMark | Rich Seymour - Update XMLHttpRequest.ios.js | Nick Poulden - Warn about missing dependencies for issue #16 | Andrew McCloud
facebook · Feb 8, 2015 · 39f475e · 39f475e
1 parent 462c7ed
commit 39f475e
Show file tree

Hide file tree

Showing 13 changed files with 125 additions and 58 deletions.
diff --git a/Examples/TicTacToe/TicTacToeApp.js b/Examples/TicTacToe/TicTacToeApp.js
@@ -40,7 +40,7 @@ class Board {
     return this;
   }
 
-  hasMove(row: number, col: number): boolean {
+  hasMark(row: number, col: number): boolean {
     return this.grid[row][col] !== 0;
   }
 
@@ -132,7 +132,10 @@ var Cell = React.createClass({
 
   render() {
     return (
-      <TouchableHighlight onPress={this.props.onPress} underlayColor={'clear'} activeOpacity={0.5}>
+      <TouchableHighlight
+        onPress={this.props.onPress}
+        underlayColor="transparent"
+        activeOpacity={0.5}>
         <View style={[styles.cell, this.cellStyle()]}>
           <Image source={{uri: this.imageContents()}} />
         </View>
@@ -161,7 +164,10 @@ var GameEndOverlay = React.createClass({
     return (
       <View style={styles.overlay}>
         <Text style={styles.overlayMessage}>{message}</Text>
-        <TouchableHighlight onPress={this.props.onRestart} underlayColor={'clear'} activeOpacity={0.5}>
+        <TouchableHighlight
+          onPress={this.props.onRestart}
+          underlayColor="transparent"
+          activeOpacity={0.5}>
           <View style={styles.newGame}>
             <Text style={styles.newGameText}>New Game</Text>
           </View>
@@ -185,7 +191,7 @@ var TicTacToeApp = React.createClass({
   },
 
   handleCellPress(row: number, col: number) {
-    if (this.state.board.hasMove(row, col)) {
+    if (this.state.board.hasMark(row, col)) {
       return;
     }
 
@@ -214,7 +220,10 @@ var TicTacToeApp = React.createClass({
         <View style={styles.board}>
           {rows}
         </View>
-        <GameEndOverlay board={this.state.board} onRestart={this.restartGame} />
+        <GameEndOverlay
+          board={this.state.board}
+          onRestart={this.restartGame}
+        />
       </View>
     );
   }

diff --git a/Examples/UIExplorer/LayoutExample.js b/Examples/UIExplorer/LayoutExample.js
@@ -124,7 +124,7 @@ var LayoutExample = React.createClass({
         </UIExplorerBlock>
         <UIExplorerBlock title="Flex Wrap">
           <CircleBlock style={{flexWrap: 'wrap'}}>
-            {'oooooooooooooooo'.split('').map(() => <Circle />)}
+            {'oooooooooooooooo'.split('').map((char, i) => <Circle key={i} />)}
           </CircleBlock>
         </UIExplorerBlock>
       </UIExplorerPage>

diff --git a/Examples/UIExplorer/NavigatorIOSExample.js b/Examples/UIExplorer/NavigatorIOSExample.js
@@ -60,6 +60,7 @@ var NavigatorIOSExample = React.createClass({
             this.props.navigator.push({
               title: NavigatorIOSExample.title,
               component: NavigatorIOSExample,
+              backButtonTitle: 'Custom Back',
               passProps: {topExampleRoute: this.props.topExampleRoute || this.props.route},
             });
           })}

diff --git a/Examples/UIExplorer/ScrollViewExample.js b/Examples/UIExplorer/ScrollViewExample.js
@@ -54,7 +54,7 @@ var Thumb = React.createClass({
 
 var THUMBS = ['https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-ash3/t39.1997/p128x128/851549_767334479959628_274486868_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851561_767334496626293_1958532586_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-ash3/t39.1997/p128x128/851579_767334503292959_179092627_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851589_767334513292958_1747022277_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851563_767334559959620_1193692107_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851593_767334566626286_1953955109_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851591_767334523292957_797560749_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851567_767334529959623_843148472_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851548_767334489959627_794462220_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851575_767334539959622_441598241_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-ash3/t39.1997/p128x128/851573_767334549959621_534583464_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851583_767334573292952_1519550680_n.png'];
 THUMBS = THUMBS.concat(THUMBS); // double length of THUMBS
-var createThumbRow = (uri, i) => <Thumb uri={uri}/>;
+var createThumbRow = (uri, i) => <Thumb key={i} uri={uri} />;
 
 var styles = StyleSheet.create({
   scrollView: {

diff --git a/Examples/UIExplorer/UIExplorerList.js b/Examples/UIExplorer/UIExplorerList.js
@@ -45,10 +45,10 @@ var UIExplorerList = React.createClass({
     );
   },
 
-  _renderRow: function(example) {
+  _renderRow: function(example, i) {
     invariant(example.title, 'Example must provide a title.');
     return (
-      <View>
+      <View key={i}>
         <TouchableHighlight onPress={() => this._onPressRow(example)}>
           <View style={styles.row}>
             <Text style={styles.rowTitleText}>

diff --git a/Examples/UIExplorer/createExamplePage.js b/Examples/UIExplorer/createExamplePage.js
@@ -20,7 +20,7 @@ var createExamplePage = function(title, exampleModule) {
       description: exampleModule.description,
     },
 
-    getBlock: function(example) {
+    getBlock: function(example, i) {
       // Hack warning: This is a hack because the www UI explorer requires
       // renderComponent to be called.
       var originalRenderComponent = React.renderComponent;
@@ -37,6 +37,7 @@ var createExamplePage = function(title, exampleModule) {
       React.render = originalRender;
       return (
         <UIExplorerBlock
+          key={i}
           title={example.title}
           description={example.description}>
           {renderedComponent}

diff --git a/Libraries/Components/ListView/ListView.js b/Libraries/Components/ListView/ListView.js
@@ -104,7 +104,7 @@ var ListView = React.createClass({
       initialListSize: PropTypes.number,
       /**
        * Called when all rows have been rendered and the list has been scrolled
-       * to within onEndReachedThreashold of the bottom.  The native scroll
+       * to within onEndReachedThreshold of the bottom.  The native scroll
        * event is provided.
        */
       onEndReached: PropTypes.func,

diff --git a/Libraries/Components/Navigation/NavigatorIOS.ios.js b/Libraries/Components/Navigation/NavigatorIOS.ios.js
@@ -179,6 +179,13 @@ var NavigatorIOS = React.createClass({
        */
       passProps: PropTypes.object,
 
+      /**
+       * If set, the left header button will appear with this name. Note that
+       * this doesn't apply for the header of the current view, but the ones
+       * of the views that are pushed afterward.
+       */
+      backButtonTitle: PropTypes.string,
+
       /**
        * If set, the right header button will appear with this name
        */
@@ -493,6 +500,7 @@ var NavigatorIOS = React.createClass({
             this.props.itemWrapperStyle,
             route.wrapperStyle
           ]}
+          backButtonTitle={route.backButtonTitle}
           rightButtonTitle={route.rightButtonTitle}
           onNavRightButtonTap={route.onRightButtonPress}
           tintColor={this.props.tintColor}>

diff --git a/Libraries/XMLHttpRequest/XMLHttpRequest.ios.js b/Libraries/XMLHttpRequest/XMLHttpRequest.ios.js
@@ -58,6 +58,11 @@ class XMLHttpRequest {
     return '';
   }
 
+  getResponseHeader(header: string): ?string {
+    /* Stub */
+    return '';
+  }
+
   setRequestHeader(header: string, value: any): void {
     this._headers[header] = value;
   }