Skip to content

Commit

Permalink
2015-02-07 updates
Browse files Browse the repository at this point in the history
- Fixes reference to ReactPackager middleware | Tyler Smalley
- [ReactKit] Fix bug where <Text /> did not refresh (in RCTText) | Alex Akers
- Removed duplication in react-native.js | Nick Lockwood
- [ReactNative] Patch up ReactPerf to work again | Ben Alpert
  • Loading branch information
vjeux committed Feb 7, 2015
1 parent 9674c99 commit 462c7ed
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 48 deletions.
9 changes: 8 additions & 1 deletion Libraries/ReactIOS/ReactIOSMount.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
var RKUIManager = require('NativeModulesDeprecated').RKUIManager;

var ReactIOSTagHandles = require('ReactIOSTagHandles');
var ReactPerf = require('ReactPerf');

var instantiateReactComponent = require('instantiateReactComponent');
var invariant = require('invariant');
Expand Down Expand Up @@ -47,7 +48,7 @@ var ReactIOSMount = {
TOP_ROOT_NODE_IDS[topRootNodeID] = true;

var childRootNodeID = instanceNumberToChildRootID(
topRootNodeID,
topRootNodeID,
ReactIOSMount.instanceCount++
);
ReactIOSMount._instancesByContainerID[topRootNodeID] = instance;
Expand Down Expand Up @@ -113,4 +114,10 @@ var ReactIOSMount = {
}
};

ReactIOSMount.renderComponent = ReactPerf.measure(
'ReactMount',
'_renderNewRootComponent',
ReactIOSMount.renderComponent
);

module.exports = ReactIOSMount;
62 changes: 20 additions & 42 deletions Libraries/react-native/react-native.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,49 +5,27 @@
*/
'use strict';

var Bundler = require('Bundler');
var ExpandingText = require('ExpandingText');
var Image = require('Image');
var ListView = require('ListView');
var ListViewDataSource = require('ListViewDataSource');
var NavigatorIOS = require('NavigatorIOS');
var StatusBarIOS = require('StatusBarIOS');
var PixelRatio = require('PixelRatio');
var React = require('React');
var ScrollView = require('ScrollView');
var SpinnerIOS = require('SpinnerIOS');
var StyleSheet = require('StyleSheet');
var Text = require('Text');
var TextInput = require('TextInput');
var TimerMixin = require('TimerMixin');
var TouchableHighlight = require('TouchableHighlight');
var TouchableWithoutFeedback = require('TouchableWithoutFeedback');
var View = require('View');

var invariant = require('invariant');
var ix = require('ix');

var ReactNative = {
...React,
Bundler,
ExpandingText,
Image,
ListView,
ListViewDataSource,
NavigatorIOS,
StatusBarIOS,
PixelRatio,
ScrollView,
SpinnerIOS,
StyleSheet,
Text,
TextInput,
TimerMixin,
TouchableHighlight,
TouchableWithoutFeedback,
View,
invariant,
ix,
...require('React'),
Bundler: require('Bundler'),
ExpandingText: require('ExpandingText'),
Image: require('Image'),
ListView: require('ListView'),
ListViewDataSource: require('ListViewDataSource'),
NavigatorIOS: require('NavigatorIOS'),
PixelRatio: require('PixelRatio'),
ScrollView: require('ScrollView'),
SpinnerIOS: require('SpinnerIOS'),
StatusBarIOS: require('StatusBarIOS'),
StyleSheet: require('StyleSheet'),
Text: require('Text'),
TextInput: require('TextInput'),
TimerMixin: require('TimerMixin'),
TouchableHighlight: require('TouchableHighlight'),
TouchableWithoutFeedback: require('TouchableWithoutFeedback'),
View: require('View'),
invariant: require('invariant'),
ix: require('ix'),
};

module.exports = ReactNative;
2 changes: 1 addition & 1 deletion ReactKit/Views/RCTText.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

@property (nonatomic, copy) NSAttributedString *attributedText;
@property (nonatomic, assign) NSLineBreakMode lineBreakMode;
@property (nonatomic, assign) NSInteger numberOfLines;
@property (nonatomic, assign) NSUInteger numberOfLines;

- (NSNumber *)reactTagAtPoint:(CGPoint)point;

Expand Down
9 changes: 6 additions & 3 deletions ReactKit/Views/RCTText.m
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,18 @@ - (NSAttributedString *)attributedText
- (void)setAttributedText:(NSAttributedString *)attributedText
{
[_textStorage setAttributedString:attributedText];
[self setNeedsDisplay];
}

- (NSInteger)numberOfLines
- (NSUInteger)numberOfLines
{
return _textContainer.maximumNumberOfLines;
}

- (void)setNumberOfLines:(NSInteger)numberOfLines
- (void)setNumberOfLines:(NSUInteger)numberOfLines
{
_textContainer.maximumNumberOfLines = MAX(0, numberOfLines);
_textContainer.maximumNumberOfLines = numberOfLines;
[self setNeedsDisplay];
}

- (NSLineBreakMode)lineBreakMode
Expand All @@ -60,6 +62,7 @@ - (NSLineBreakMode)lineBreakMode
- (void)setLineBreakMode:(NSLineBreakMode)lineBreakMode
{
_textContainer.lineBreakMode = lineBreakMode;
[self setNeedsDisplay];
}

- (void)layoutSubviews
Expand Down
2 changes: 1 addition & 1 deletion packager/packager.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function openStackFrameInEditor(req, res, next) {
}

function getAppMiddleware(options) {
return ReactPackager.catalystMiddleware({
return ReactPackager.middleware({
dev: true,
projectRoot: options.projectRoot,
blacklistRE: blacklist(false),
Expand Down

0 comments on commit 462c7ed

Please sign in to comment.