Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the upgrading guide #803

Merged
merged 4 commits into from
Feb 25, 2019
Merged

docs: update the upgrading guide #803

merged 4 commits into from
Feb 25, 2019

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Feb 22, 2019 •
edited
Loading

Latest React Native CLI will bring an improved upgrade command, see: react-native-community/cli#176

This PR attempts to document it.

cc @cpojer @pvinis @kelset

@thymikee thymikee force-pushed the feat/rn-upgrade branch 2 times, most recently from ecdf018 to c9a38ff Compare February 22, 2019 16:11
@react-native-bot
Copy link

react-native-bot commented Feb 22, 2019 •
edited
Loading

Deploy preview for react-native ready!

Built with commit 750e59b

https://deploy-preview-803--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

@kelset kelset requested review from kelset and cpojer February 22, 2019 17:59
kelset
kelset approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

two things:

  1. would you mind only removing all the references to Create React Native App since it doesn't exist anymore?

  2. maybe add a link the react native CLI info? (I'll leave a suggestion for that)

kelset
kelset reviewed Feb 22, 2019
View reviewed changes
docs/upgrading.md Outdated Show resolved Hide resolved
kelset and others added 2 commits February 22, 2019 20:16
@kelset @thymikee
Update docs/upgrading.md
6fa4a91 
Co-Authored-By: thymikee <thymikee@gmail.com>
@thymikee
cleanup CRNA mentions
88d0b81
pvinis
pvinis approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@pvinis pvinis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 💪💪

@thymikee
Copy link
Contributor Author

Feedback is addressed, I believe :)

cpojer
cpojer approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@cpojer cpojer merged commit 519ec1e into facebook:master Feb 25, 2019
@thymikee thymikee deleted the feat/rn-upgrade branch February 27, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

@cpojer cpojer cpojer approved these changes

@pvinis pvinis pvinis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thymikee @react-native-bot @cpojer @pvinis @kelset