-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Copy all level props for ‘Copy element props’ feature #1037
Conversation
This helped a lot in grabbing fixtures for some unit tests. Thanks! |
@zinoviev FYI I've rebased your work on the latest master and made sure everything is working again: https://github.com/suitupalex/react-devtools/tree/feature/deep-copy-props |
@zinoviev yup! I had to fix it because I've been relying on it to capture fixtures. I've verified it still works after the rebase. Edit: I guess I should say I've tested it in Chrome. I haven't tested it on Firefox. |
Any news on this? Just ran across it in the wild, and ended up setting a breakpoint and doing |
@davezatch I guess it will wait for review forever, unless someone from React core team need this function for his own |
For what it's worth, the new DevTools (not yet released) has copy-props built in. It seems unlikely that we'll review or merge any non-urgent PRs for the legacy DevTools (this repo) until we've released the new one because we just don't have the bandwidth. (For the most part, I'm the only one working on DevTools, and it's not the only thing I'm working on either.) |
Ok, thanks for the update @bvaughn. I don't suppose there's any kind of timeline for the devtools rewrite? |
Not for a final release, no. There's an early preview release you can test drive on the demo site but there are some known bugs. |
Just chiming in that I would love to see this feature ship! Thanks for working on this 👍 |
React DevTools has been rewritten and recently launched a new version 4 UI 🎉 The source code for this rewrite was done in a separate repository and is being merged into the main React repo. Thank you for taking the time to contribute to this extension 🙇♂️ Because this PR is for the version code base, I am closing it. If you'd like to contribute to the new extension, please visit the new repository. |
PR for #843