Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools copy operations don't work in Firefox #17652

Closed
bvaughn opened this issue Dec 18, 2019 · 2 comments
Closed

DevTools copy operations don't work in Firefox #17652

bvaughn opened this issue Dec 18, 2019 · 2 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Dec 18, 2019

Attempting to copy a prop using the new context menu (#17608) prints the following error for Firefox:

Error: Unable to copy. Perhaps it's not available in your browser?

Firefox itself does support document.execCommand('copy') if it's within the context of an event handler, but it looks like this does not include events that originated within an extension.

Looks like this was also an issue for DevTools v3: facebook/react-devtools#843

Under the hood we are using clipboard-js for this.

@zinoviev
Copy link

zinoviev commented Dec 22, 2019

@bvaughn I used to work on facebook/react-devtools#843 - facebook/react-devtools#1037 and as far as I remember it works for both Chrome and Firefox for me. Maybe I totaly worng about firefox, but I would like to check this issue

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 22, 2019

@zinoviev It works under certain conditions, but not one where a click event in the extension tries to run document.execCommand("copy") in the page. I spoke with the Mozilla folks about this issue Friday, and they're at least aware of it. Not sure the exact path forward (although if you'd like to take a look and lend a hand, please do!)

I think in the meanwhile- I'm going to close this issue and roll it into #17681 since a few Firefox folks are also tracking that one.

@bvaughn bvaughn closed this as completed Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants