Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run flaky tests on firefox browsers #6411

Merged
merged 1 commit into from
Jul 17, 2024
Merged

CI: run flaky tests on firefox browsers #6411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/call-e2e-all-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ jobs:
strategy:
matrix:
node-version: [18.18.0]
# Currently using single browser & os combination for flaky tests to reduce cost impact
browser: ['chromium']
browser: ['chromium', 'firefox']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use all browsers ? Not just Firefox

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry just saw this, the other is webkit, we can see how it goes with adding firefox. just alittle weary there will be alot of flaky jobs (since its 3 per browser)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the workflow anyways run separately for all browsers after isolation, so running 2 or 3 browser will not make a difference, but the objective was to see if flakyness appears in isolation or not and fix it ..

editor-mode: ['rich-text', 'plain-text', 'rich-text-with-collab']
events-mode: ['modern-events']
uses: ./.github/workflows/call-e2e-test.yml
Expand Down
Loading