CI: run flaky tests on firefox browsers #6411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
Sahejkm
approved these changes
Jul 17, 2024
Sahejkm
reviewed
Jul 17, 2024
| @@ -146,8 +146,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| node-version: [18.18.0] | |||
| # Currently using single browser & os combination for flaky tests to reduce cost impact | |||
| browser: ['chromium'] | |||
| browser: ['chromium', 'firefox'] | |||
There was a problem hiding this comment.
Should we use all browsers ? Not just Firefox
There was a problem hiding this comment.
sorry just saw this, the other is webkit, we can see how it goes with adding firefox. just alittle weary there will be alot of flaky jobs (since its 3 per browser)
There was a problem hiding this comment.
I think the workflow anyways run separately for all browsers after isolation, so running 2 or 3 browser will not make a difference, but the objective was to see if flakyness appears in isolation or not and fix it ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes in this pull request
to see if putting flaky test in a less crowded run helps with the flakiness since most of the flaky tests are on firefox
Test plan
wait for CI to run, there should be a FF job for flaky test