[rexical-react] Bug Fix: Headings inside collapsible sections are lost when Table of Contents is re-initialized #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatsiarynaDzibrova
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
ivailop7
approved these changes
Jul 4, 2024
2wheeh
pushed a commit
to 2wheeh/lexical
that referenced
this pull request
Jul 17, 2024
…t when Table of Contents is re-initialized (facebook#6371)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr changes the logic in TableOfContentsPlugin initialization. Previously only the headings on the highest level were added to the Table of Contents. Now the tree traversal is executed, so that the headings on all level are processed correctly, including headings inside Collapsible Sections and Tables.
Test plan
Before
The headings inside Collapsible sections disappear when ToC switched is toggled on and off.
After
The Table of Contents stays the same when ToC switched is toggled on and off.