Allow table selection when cells are already selected #4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterBul
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
I am a little uncertain if checking the grid selection in the test like this is a stable enough solution, but I guess you can be the judge of that. |
|
Started some rework on table selection in #4689 which seem to address your case, but regardless, having more tests is great. Thank you! |
fantactuka
approved these changes
Jun 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier on table selection, previous selection was cleared before immediately returning on mousedown if table cells were already selected. By not returning, but still clearing selection, we are able to make a proper new table selection instead of ending up in bad states.
Fixes issue #4697
See issue for more details.
Before:
table-selection-firefox.mp4
table-selection-sidekick-chromium.mp4
After:
table-selection-firefox-working.mp4
table-selection-sidekick-chromium-working.mp4