-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table selection keyboard controls #4689
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
0857d7c
to
5d6ea8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks great!
Some feedback:
- Should the tab key select the entire content of the next cell?
- Why doesn't the tab key work with a range selection inside a cell? Is this intended?
- I believe shift+Arrow at a boundary should first select the entire cell instead of two?
- I don't agree with the Escape key behavior, it should mimic a browser RangeSelection
I think the current approach is good even though (as discussed offline) we might want to change some bits to rely on computed position instead of boundaries but this one will certainly perform much better for now
Some feedback:
For both above: I didn't change tab key for now, I think it might need this changes plus some tweaks to work with tabIndent plugin
Talked about it a bit offline, tldr: boundary calculation are intentionally simplified for this version to test a bit, can make it more precise if need (might cover some edge cases)
Yeah, it's probably a better approach. Might be a bit tricky to unhighlight cells on blur and re-highlight on focusing, will have it as a follow up |
This diff addresses some table selection around keyboard (arrow/tab) controls:
hasTabHandler
to enable tab key switching between cells. Although handle itself makes sense, when app tends to have more complex content within cells like lists, code, or inventible paragraphs tab override to jump through cells does not make much sense