Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed character styles popup plugin #2456

Merged
merged 3 commits into from
Jun 17, 2022
Merged

renamed character styles popup plugin #2456

merged 3 commits into from
Jun 17, 2022

Conversation

harish-sethuraman
Copy link
Contributor

Addressing

I felt like FloatingFormatter seemed like a better name. Feel free to suggest other names if any. 😅

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2022
@vercel
Copy link

vercel bot commented Jun 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 10:14AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 10:14AM (UTC)

@zurfyx
Copy link
Member

zurfyx commented Jun 17, 2022

Well, FloatingToolbar is the only one that returns proper results when Googling -> https://www.google.com/search?q=floating+toolbar

Also, appreciate you're taking this! If you want you make as well rename some similar wording inside this file like:

  • useCharacterStylesPopup
  • FloatingCharacterStylesEditor

@harish-sethuraman
Copy link
Contributor Author

harish-sethuraman commented Jun 17, 2022 •
edited
Loading

character-style-popup should I rename classnames and styles too?

@zurfyx
Copy link
Member

zurfyx commented Jun 17, 2022

character-style-popup should I rename classnames and styles too?

That would be awesome. Also, @thegreatercurve just suggested TextFormatFloatingToolbar, I quite like that one, WDYT?

@harish-sethuraman
Copy link
Contributor Author

TextFormatFloatingToolbar -> FloatingTextFormatToolbar may be? It would be easy to grasp if floating was at the start?

@zurfyx
Copy link
Member

zurfyx commented Jun 17, 2022 •
edited
Loading

TextFormatFloatingToolbar -> FloatingTextFormatToolbar may be? It would be easy to grasp if floating was at the start?

Prob won't make a difference when you search via CMD + P but no strong opinions on this!

zurfyx
zurfyx approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zurfyx zurfyx merged commit 9b3586b into facebook:main Jun 17, 2022
@thegreatercurve thegreatercurve mentioned this pull request Jun 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harish-sethuraman @zurfyx @facebook-github-bot