Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discussion] Rename CharacterStylesPopupPlugin to FloatingToolbar? #2446

Closed
zurfyx opened this issue Jun 16, 2022 · 4 comments
Closed

[Discussion] Rename CharacterStylesPopupPlugin to FloatingToolbar? #2446

zurfyx opened this issue Jun 16, 2022 · 4 comments
Labels
discussion enhancement Improvement over existing feature good first issue Good for newcomers

Comments

@zurfyx
Copy link
Member

zurfyx commented Jun 16, 2022

It always takes me 30 ages to find this plugin, I wonder if we should rename it
@zurfyx zurfyx added enhancement Improvement over existing feature good first issue Good for newcomers discussion labels Jun 16, 2022
@harish-sethuraman
Copy link
Contributor

may be FloatingFormatter?

@harish-sethuraman harish-sethuraman mentioned this issue Jun 17, 2022
Merged
@thegreatercurve
Copy link
Contributor

We have other floating toolbars some maybe something more specific like TextFormatFloatingToolbar?

@harish-sethuraman
Copy link
Contributor

TextFormatFloatingToolbar -> FloatingTextFormatToolbar may be? It would be easy to grasp if floating was at the start?

@thegreatercurve
Copy link
Contributor

Closed by #2456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement Improvement over existing feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zurfyx @thegreatercurve @harish-sethuraman