Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-docs): do not echo git history to console #5906

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

In #5904 I forgot to inspect the log... shell.exec outputs the result to the console which isn't necessary.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 8, 2021
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Size Change: -3 B (0%)

Total Size: 881 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.2 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/assets/js/main.********.js 474 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB 0 B
website/build/docs/installation/index.html 51.5 kB -3 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Nov 8, 2021

✔️ [V2]

🔨 Explore the source changes: a62bfc0

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61891c931a5b010008bc92b3

😎 Browse the preview: https://deploy-preview-5906--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5906--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit f12c390 into main Nov 8, 2021
@Josh-Cena Josh-Cena deleted the jc/git-history-silent branch November 8, 2021 13:03
@Josh-Cena Josh-Cena added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants