refactor(content-docs): use shelljs instead of execa #5904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #4455. Up to this point, the only thing that we should fix is removing
execa
in favor ofshelljs
. Now, we only havefs-extra
for FS operations andshelljs
for "actual shell operations".del
is used in a forked plugin which I think we shouldn't touch,mkdirp
isn't used anymore.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Updated test cases a little bit; can also check preview that updated data is rendered correctly