Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(content-docs): use shelljs instead of execa #5904

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Resolve #4455. Up to this point, the only thing that we should fix is removing execa in favor of shelljs. Now, we only have fs-extra for FS operations and shelljs for "actual shell operations". del is used in a forked plugin which I think we shouldn't touch, mkdirp isn't used anymore.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Updated test cases a little bit; can also check preview that updated data is rendered correctly

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 8, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 8, 2021
@netlify
Copy link

netlify bot commented Nov 8, 2021

✔️ [V2]

🔨 Explore the source changes: f2455ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6188d0e122bc1e0007373368

😎 Browse the preview: https://deploy-preview-5904--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 78
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5904--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit 334b439 into main Nov 8, 2021
@Josh-Cena Josh-Cena deleted the jc/remove-execa branch November 8, 2021 07:33
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Size Change: -3 B (0%)

Total Size: 881 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.2 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/assets/js/main.********.js 474 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB 0 B
website/build/docs/installation/index.html 51.5 kB -3 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplicate npm libraries (shelljs/execa, del/mkdirp)
2 participants