address lint+pyre failures #2244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54492153 |
Differential Revision: https://internalfb.com/D54469983
Summary: Pull Request resolved: facebook#2244 OSS linter seems to be failing (https://github.com/facebook/Ax/actions/runs/8142510522/job/22252224158). This addresses the observed failures. May be related to https://fb.workplace.com/groups/aeeng/permalink/1603431750415515/ Also moves some pyre-ignores that were out of place, per failing pyre command. Reviewed By: mpolson64 Differential Revision: D54492153
|
This pull request was exported from Phabricator. Differential Revision: D54492153 |
bernardbeckerman
force-pushed
the
export-D54492153
branch
from
68b5309 to
1b5661c
Compare
|
This pull request has been merged in d3f464d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
OSS linter seems to be failing (https://github.com/facebook/Ax/actions/runs/8142510522/job/22252224158). This addresses the observed failures.
May be related to https://fb.workplace.com/groups/aeeng/permalink/1603431750415515/
Also moves some pyre-ignores that were out of place, per failing pyre command.
Reviewed By: mpolson64
Differential Revision: D54492153