Skip to content

Commit

Permalink
address lint+pyre failures
Browse files Browse the repository at this point in the history
Summary:
OSS linter seems to be failing (https://github.com/facebook/Ax/actions/runs/8142510522/job/22252224158). This addresses the observed failures.

May be related to https://fb.workplace.com/groups/aeeng/permalink/1603431750415515/

Also moves some pyre-ignores that were out of place, per failing pyre command.

Reviewed By: mpolson64

Differential Revision: D54492153
  • Loading branch information
bernardbeckerman authored and facebook-github-bot committed Mar 4, 2024
1 parent 9a749c5 commit 68b5309
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
5 changes: 2 additions & 3 deletions ax/runners/tests/test_single_running_trial_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
from ax.utils.testing.core_stubs import get_branin_experiment


class SyntheticRunnerWithSingleRunningTrial(
SingleRunningTrialMixin, SyntheticRunner
): ...
class SyntheticRunnerWithSingleRunningTrial(SingleRunningTrialMixin, SyntheticRunner):
pass


class SingleRunningTrialMixinTest(TestCase):
Expand Down
5 changes: 2 additions & 3 deletions ax/service/tests/scheduler_test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,8 @@ def poll_trial_status(
return {}


class SyntheticRunnerWithSingleRunningTrial(
SingleRunningTrialMixin, SyntheticRunner
): ...
class SyntheticRunnerWithSingleRunningTrial(SingleRunningTrialMixin, SyntheticRunner):
pass


class SyntheticRunnerWithPredictableStatusPolling(SyntheticRunner):
Expand Down
3 changes: 2 additions & 1 deletion ax/service/tests/test_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
from ax.service.tests.scheduler_test_utils import AxSchedulerTestCase


class TestAxScheduler(AxSchedulerTestCase): ...
class TestAxScheduler(AxSchedulerTestCase):
pass
3 changes: 2 additions & 1 deletion ax/service/utils/instantiation.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,9 @@ def _make_fixed_param(
parameter_type=(
cls._get_parameter_type(type(value)) # pyre-ignore[6]
if parameter_type is None
# pyre-ignore[6]
else cls._get_parameter_type(PARAM_TYPES[parameter_type])
), # pyre-ignore[6]
),
value=value, # pyre-ignore[6]
is_fidelity=checked_cast(bool, representation.get("is_fidelity", False)),
target_value=representation.get("target_value", None), # pyre-ignore[6]
Expand Down

0 comments on commit 68b5309

Please sign in to comment.