chore(TS) Remove ts-nocheck from filters ( resize filter will have its own pr )

src/filters/2d_backend.class.ts

@@ -2,7 +2,7 @@
  * Canvas 2D filter backend.
  */
 import type { BaseFilter } from './base_filter.class';
-import { T2DPipelineState } from './typedefs';
+import { T2DPipelineState, TPipelineResources } from './typedefs';
 
 export class Canvas2dFilterBackend {
   /**
@@ -12,7 +12,7 @@ export class Canvas2dFilterBackend {
    * in this object there will be appended some canvases, created once, resized sometimes
    * cleared never. Clearing is left to the developer.
    **/
-  resources = {};
+  resources: TPipelineResources = {};
 
   /**
    * Apply a set of filters against a source image and draw the filtered output

src/filters/base_filter.class.ts

@@ -19,6 +19,9 @@ export type AbstractBaseFilterOptions<T> = {
 
 export type BaseFilterOptions = AbstractBaseFilterOptions<string>;
 
+// eslint-disable-next-line @typescript-eslint/no-empty-interface
+export interface AnyFilter extends AbstractBaseFilter<string | Record<string, string>> {};
+
 export abstract class AbstractBaseFilter<T> {
   /**
    * Filter type
@@ -47,15 +50,7 @@ export abstract class AbstractBaseFilter<T> {
    * Constructor
    * @param {Object} [options] Options object
    */
-  constructor(options: Partial<AbstractBaseFilterOptions<T>> = {}) {
-    this.setOptions(options);
-  }
-
-  /**
-   * Sets filter's properties from options
-   * @param {Object} [options] Options object
-   */
-  setOptions(options: Record<string, any>) {
+  constructor(options: Partial<AbstractBaseFilterOptions<T>> & Record<string, any> = {}) {
     Object.assign(this, options);
   }
 

src/filters/blendimage_filter.class.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import { Image } from '../shapes/image.class';
 import type { TClassProperties } from '../typedefs';
 import { createCanvasElement } from '../util/misc/dom';
@@ -100,7 +99,7 @@ export class BlendImage extends AbstractBaseFilter<Record<string, string>> {
       resources.blendImage = createCanvasElement();
     }
     const canvas1 = resources.blendImage;
-    const context = canvas1.getContext('2d');
+    const context = canvas1.getContext('2d')!;
     if (canvas1.width !== width || canvas1.height !== height) {
       canvas1.width = width;
       canvas1.height = height;
@@ -194,7 +193,7 @@ export class BlendImage extends AbstractBaseFilter<Record<string, string>> {
    * @param {AbortSignal} [options.signal] handle aborting image loading, see https://developer.mozilla.org/en-US/docs/Web/API/AbortController/signal
    * @returns {Promise<BlendImage>}
    */
-  static fromObject(object, options) {
+  static fromObject(object: Record<string, any>, options: { signal: AbortSignal }) {
     return Image.fromObject(object.image, options).then(
       (image) => new BlendImage({ ...object, image })
     );

src/filters/blur_filter.class.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import type { TClassProperties } from '../typedefs';
 import { createCanvasElement } from '../util/misc/dom';
 import { BaseFilter } from './base_filter.class';
@@ -65,14 +64,14 @@ export class Blur extends BaseFilter {
       resources.blurLayer1 = createCanvasElement();
       resources.blurLayer2 = createCanvasElement();
     }
-    const canvas1 = resources.blurLayer1;
-    const canvas2 = resources.blurLayer2;
+    const canvas1 = resources.blurLayer1!;
+    const canvas2 = resources.blurLayer2!;
     if (canvas1.width !== width || canvas1.height !== height) {
       canvas2.width = canvas1.width = width;
       canvas2.height = canvas1.height = height;
     }
-    const ctx1 = canvas1.getContext('2d'),
-      ctx2 = canvas2.getContext('2d'),
+    const ctx1 = canvas1.getContext('2d')!,
+      ctx2 = canvas2.getContext('2d')!,
       nSamples = 15,
       blur = this.blur * 0.06 * 0.5;
     let random, percent, j, i;

src/filters/composed_filter.class.ts

@@ -1,9 +1,8 @@
-// @ts-nocheck
 import type { TClassProperties } from '../typedefs';
 import {
-  AbstractBaseFilter,
+  type AnyFilter,
   BaseFilter,
-  BaseFilterOptions,
+  type BaseFilterOptions,
 } from './base_filter.class';
 import type { T2DPipelineState, TWebGLPipelineState } from './typedefs';
 import { isWebGLPipelineState } from './typedefs';
@@ -12,16 +11,17 @@ import { classRegistry } from '../util/class_registry';
 /**
  * A container class that knows how to apply a sequence of filters to an input image.
  */
+// @ts-expect-error
 export class Composed extends BaseFilter {
   /**
    * A non sparse array of filters to apply
    */
-  declare subFilters: AbstractBaseFilter[];
+  declare subFilters: AnyFilter[];
 
   constructor({
     subFilters = [],
     ...options
-  }: Partial<BaseFilterOptions & { subFilters: AbstractBaseFilter[] }> = {}) {
+  }: Partial<BaseFilterOptions & { subFilters: AnyFilter[] }> = {}) {
     super(options);
     this.subFilters = subFilters;
   }
@@ -65,9 +65,9 @@ export class Composed extends BaseFilter {
    * @param {AbortSignal} [options.signal] handle aborting `BlendImage` filter loading, see https://developer.mozilla.org/en-US/docs/Web/API/AbortController/signal
    * @returns {Promise<Composed>}
    */
-  static fromObject(object, options) {
+  static fromObject(object: Record<string, any>, options: { signal: AbortSignal }) {
     return Promise.all(
-      ((object.subFilters || []) as AbstractBaseFilter[]).map((filter) =>
+      ((object.subFilters || []) as AnyFilter[]).map((filter) =>
         classRegistry.getClass(filter.type).fromObject(filter, options)
       )
     ).then((enlivedFilters) => new Composed({ subFilters: enlivedFilters }));

src/filters/typedefs.ts

@@ -5,6 +5,12 @@ export type TProgramCache = any;
 
 export type TTextureCache = any;
 
+export type TPipelineResources = {
+  blendImage?: HTMLCanvasElement;
+  blurLayer1?: HTMLCanvasElement;
+  blurLayer2?: HTMLCanvasElement;
+} & Record<string, unknown>;
+
 export type TWebGLPipelineState = {
   filterBackend: WebGLFilterBackend;
   originalWidth: number;

src/filters/webgl_backend.class.ts

@@ -1,7 +1,7 @@
 import { getEnv } from '../env';
 import { config } from '../config';
 import { createCanvasElement } from '../util/misc/dom';
-import { TWebGLPipelineState, TProgramCache, TTextureCache } from './typedefs';
+import { TWebGLPipelineState, TProgramCache, TTextureCache, TPipelineResources } from './typedefs';
 
 export class WebGLFilterBackend {
   declare tileSize: number;
@@ -46,7 +46,7 @@ export class WebGLFilterBackend {
    * in this object there will be appended some canvases, created once, resized sometimes
    * cleared never. Clearing is left to the developer.
    **/
-  resources = {};
+  resources: TPipelineResources = {};
 
   constructor({ tileSize = config.textureSize } = {}) {
     this.tileSize = tileSize;