-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS) Remove ts-nocheck from filters ( resize filter will have its own pr ) #8609
Conversation
Build Stats
|
const ctx1 = canvas1.getContext('2d'), | ||
ctx2 = canvas2.getContext('2d'), | ||
const ctx1 = canvas1.getContext('2d')!, | ||
ctx2 = canvas2.getContext('2d')!, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably need a type that is HTMLCanvasElementThatWorks that never return null on getContext('2d').
We just need to agree that if your machine has no memory to create canvases anymore fabricJS is not going to work anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can modify the global type of the window/dom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or better off,
we use AssertKeys
in createCanvasElement
Motivation
Continue TS migration
Description
Remove ts-nocheck ad do type adjustments
Changes
Gist
In Action