Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geometry): nonTransformedDimensions + strokeUniform #7639

Conversation

goodbot1356
Copy link

@ShaMan123 ShaMan123 changed the title fix(geometry): nonTransformedDimensions fix(geometry): nonTransformedDimensions + strokeUniform Jan 30, 2022
@ShaMan123
Copy link
Contributor

ShaMan123 commented Feb 1, 2022

Could you run npm run lint -- --fix and commit the changes (if it makes a giant commit first stash all changes and then restore stash - whitespace OS diffs)
We want to make contributing easier but for now it is what it is.

Adding a test is needed as well (something that breaks without your fix)

@asturur
Copy link
Member

asturur commented Feb 2, 2022

This has been proposed in the past and hasn't been done because it breaks other things.
when we talk of non transformed dimensions, the scale is not taken in consideration. is the size of the object at scale 1. so dividing by scale would bring to strange results. Getting nonTransformedDimensions of a rect when it has scale 5 or 1 should give you the same result.

All tests break, and that could be that because they are made to reflect the old behaviour, but i m not confident to accept this change because it fixes a demo.

Does it fix something else?

Let's check it more broadly. SVG import tests could be affected by this for example.

@ShaMan123
Copy link
Contributor

I think there's a need to clearly define strokeUniform.
I understand it remains the same size no matter the scale.
If so is it part of non transformed dimensions?

@asturur
Copy link
Member

asturur commented Feb 5, 2022

strokeUniform would mean that the stroke is not affected by the current transformation.
so if you deform a path stretching it on a single axis, the stroke will stay of the same size instead of being larger in some directions.
Is not the feature wrong but our stack of transform to find the size.

@asturur
Copy link
Member

asturur commented Feb 5, 2022

This behaviour needs to be fixed, just to be clear, there are multiple open issues for it.

@stale
Copy link

stale bot commented Feb 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Feb 21, 2022
@stale stale bot closed this Mar 15, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Mar 15, 2022
@ShaMan123 ShaMan123 reopened this Mar 15, 2022
@stale
Copy link

stale bot commented Apr 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_confirmation stale Issue marked as stale by the stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants