Uniform stroke pushes bounds too far

[kirill-konshin]

Version

4.6.0

Test Case

https://jsfiddle.net/dfuse/Lwpfkrx1/

Steps to reproduce

Create a path with stroke and put it inside group, set uniform stroke to false. Select the group.

You can click "Toggle uniform" and "Toggle stroke width" to see different combinations.

Expected Behavior

Selection should stick to border of stroke.

Actual Behavior

Background

When I observed this behavior, I thought it might be useful to introduce a proper inner stroke, as mentioned here #2378 so that with uniform stroke the size of stroke won't affect any dimensions.

[asturur]

This is a known issue, this is probably going away with the group rewrite.

[asturur]

For reference #6705

[ShaMan123]

@asturur is this related to the fix of #7476?

[ShaMan123]

I see strokeUniform is buggy across fabric

[ShaMan123]

related #7605 ?

[ShaMan123]

@kirill-konshin did you try #7639 ?

[asturur]

Well buggy across fabric is maybe an exageration :)
It does not work inside groups, but probably with the group rewrite this is going to change a bit.

[ShaMan123]

😳
I guess so

[asturur]

@asturur is this related to the fix of #7476?

No, but your code could use take in consideration strokeUniform, since we are not doing that.

The truth is that strokeUniform is a patch, while the real solution is probably to transform path's and polygon's points to absorbe the transformation.

strokeUniform does not apply to text either. Or if it does we are patching it manually.

Is probably safer with controlApi to build something that change the path data while you transform it, rather than having strokeUniform work consistently.

[kirill-konshin]

"transform path's and polygon's points to absorbe the transformation" I tried that, the problem is that when shape is scaled, I have to recalculate the path at least once after scaling is finished, so path "jumps" to new place.

I can recalculate at 60fps, but this may not perform well...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kirill-konshin]

Not stale. Still needs to be addressed.

[Errin890]

Any updates on this issue?

[ShaMan123]

#8040 #8344