Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2855: .withPropagationPolicy and .withGracePeriod DSL methods can't be combined resource() deletion #2896

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix #2855: .withPropagationPolicy and .withGracePeriod DSL methods can't be combined resource() deletion #2896

merged 1 commit into from
Mar 12, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Mar 12, 2021 •
edited by manusa
Loading

Description

Fix #2885

  • Add gracePeriodSeconds parameter in ResourceHandler#delete
  • Modified CascadingDeletable interface so that it includes
    GracePeriodConfigurable and PropagationPolicyConfiguratble

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
Fix fabric8io#2855: .withPropagationPolicy and .withGracePeriod DSL m…
02ba0ec 
…ethods can't be combined resource() deletion

+ Add gracePeriodSeconds parameter in ResourceHandler#delete
+ Modified CascadingDeletable interface so that it includes
GracePeriodConfigurable and PropagationPolicyConfiguratble
@manusa manusa requested a review from oscerd March 12, 2021 11:51
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

27.8% 27.8% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 8d0957c into fabric8io:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.withPropagationPolicy and .withGracePeriod DSL methods can't be combined
2 participants
@rohanKanojia @manusa