Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.withPropagationPolicy and .withGracePeriod DSL methods can't be combined #2885

Closed
manusa opened this issue Mar 9, 2021 · 2 comments · Fixed by #2896
Closed

.withPropagationPolicy and .withGracePeriod DSL methods can't be combined #2885

manusa opened this issue Mar 9, 2021 · 2 comments · Fixed by #2896
Assignees
Labels

Comments

@manusa
Copy link
Member

manusa commented Mar 9, 2021

Description

Methods withPropagationPolicy and withGracePeriod cannot be combined to produce a DELETE request with grace period and propagation policy query params.

Relates to:

@manusa manusa added the bug label Mar 9, 2021
@rohanKanojia
Copy link
Member

Umm, Is this specific to Resource API? I can see their combination in standard kubernetes resources DSL :

Boolean isDeleted = client.apps().deployments().inNamespace("ns1").withName("mydeployment").withPropagationPolicy(DeletionPropagation.FOREGROUND).withGracePeriod(10).delete();

@manusa
Copy link
Member Author

manusa commented Mar 9, 2021

I think it might be, implementations of the interface method differ. But for the BaseOperation class it won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants